Re: [HACKERS] Assertion failure in base backup code path

2014-01-07 Thread Magnus Hagander
On Tue, Jan 7, 2014 at 5:43 PM, Andres Freund wrote: > On 2014-01-07 17:40:07 +0100, Magnus Hagander wrote: > > On Tue, Dec 24, 2013 at 1:24 PM, Andres Freund >wrote: > > > > > On 2013-12-23 18:28:51 +0100, Magnus Hagander wrote: > > > > On Dec 19, 2013 12:06 AM, "Andres Freund" > > > wrote: > >

Re: [HACKERS] Assertion failure in base backup code path

2014-01-07 Thread Andres Freund
On 2014-01-07 17:40:07 +0100, Magnus Hagander wrote: > On Tue, Dec 24, 2013 at 1:24 PM, Andres Freund wrote: > > > On 2013-12-23 18:28:51 +0100, Magnus Hagander wrote: > > > On Dec 19, 2013 12:06 AM, "Andres Freund" > > wrote: > > > > > > > > Hi Magnus, > > > > > > > > It looks to me like the pat

Re: [HACKERS] Assertion failure in base backup code path

2014-01-07 Thread Magnus Hagander
On Tue, Dec 24, 2013 at 1:24 PM, Andres Freund wrote: > On 2013-12-23 18:28:51 +0100, Magnus Hagander wrote: > > On Dec 19, 2013 12:06 AM, "Andres Freund" > wrote: > > > > > > Hi Magnus, > > > > > > It looks to me like the path to do_pg_start_backup() outside of a > > > transaction context comes

Re: [HACKERS] Assertion failure in base backup code path

2013-12-24 Thread Andres Freund
On 2013-12-23 18:28:51 +0100, Magnus Hagander wrote: > On Dec 19, 2013 12:06 AM, "Andres Freund" wrote: > > > > Hi Magnus, > > > > It looks to me like the path to do_pg_start_backup() outside of a > > transaction context comes from your initial commit of the base backup > > facility. > > The probl

Re: [HACKERS] Assertion failure in base backup code path

2013-12-23 Thread Magnus Hagander
On Dec 19, 2013 12:06 AM, "Andres Freund" wrote: > > Hi Magnus, > > It looks to me like the path to do_pg_start_backup() outside of a > transaction context comes from your initial commit of the base backup > facility. > The problem is that you're not allowed to do anything leading to a > syscache/

Re: [HACKERS] Assertion failure in base backup code path

2013-12-18 Thread Andres Freund
Hi Magnus, It looks to me like the path to do_pg_start_backup() outside of a transaction context comes from your initial commit of the base backup facility. The problem is that you're not allowed to do anything leading to a syscache/catcache lookup in those contexts. Greetings, Andres Freund --

Re: [HACKERS] Assertion failure in base backup code path

2013-12-16 Thread Andres Freund
Hi, On 2013-12-16 15:08:51 +0100, Antonin Houska wrote: > In HEAD, pg_basebackup causes WAL sender to fail when the replication > user is not a superuser: > > > #0 0x7f34f671dd25 in raise () from /lib64/libc.so.6 > #1 0x7f34f671f1a8 in abort () from /lib64/libc.so.6 > #2 0x008

[HACKERS] Assertion failure in base backup code path

2013-12-16 Thread Antonin Houska
In HEAD, pg_basebackup causes WAL sender to fail when the replication user is not a superuser: #0 0x7f34f671dd25 in raise () from /lib64/libc.so.6 #1 0x7f34f671f1a8 in abort () from /lib64/libc.so.6 #2 0x008989a9 in ExceptionalCondition (conditionName=0xa51ac1 "!(IsTransactionS