Re: [HACKERS] Assertion failure when streaming logical changes

2015-04-16 Thread Heikki Linnakangas
On 04/07/2015 03:54 PM, Andres Freund wrote: On 2015-04-07 17:22:12 +0800, Craig Ringer wrote: It might be a good idea to apply this if nothing better is forthcoming. Logical decoding in WALsenders is broken at the moment. Yes. Committed. - Heikki -- Sent via pgsql-hackers mailing list (p

Re: [HACKERS] Assertion failure when streaming logical changes

2015-04-07 Thread Andres Freund
On 2015-04-07 17:22:12 +0800, Craig Ringer wrote: > It might be a good idea to apply this if nothing better is forthcoming. > Logical decoding in WALsenders is broken at the moment. Yes. > Otherwise it needs to go on the 9.5 blockers list. > > But could we get rid of those active_count manipulat

Re: [HACKERS] Assertion failure when streaming logical changes

2015-04-07 Thread Craig Ringer
On 11 February 2015 at 08:51, Heikki Linnakangas wrote: > > > The new xmin tracking code assumes that if a snapshots's regd_count > 0, > it has already been pushed to the RegisteredSnapshots heap. That assumption > doesn't hold because the logical decoding stuff creates its own snapshots > and set

Re: [HACKERS] Assertion failure when streaming logical changes

2015-04-02 Thread Craig Ringer
On 10 February 2015 at 21:43, Andres Freund wrote: > On 2015-02-10 22:06:34 +0900, Michael Paquier wrote: > > On Tue, Feb 10, 2015 at 9:46 PM, Andres Freund > > wrote: > > > > > Yea, it really looks like the above commit is to "blame". The new xmin > > > tracking infrastructure doesn't know abou

Re: [HACKERS] Assertion failure when streaming logical changes

2015-02-10 Thread Heikki Linnakangas
On 02/10/2015 02:46 PM, Andres Freund wrote: On 2015-02-10 21:20:37 +0900, Michael Paquier wrote: Using test_decoding on HEAD (cc761b1) I am seeing the following assertion failure: TRAP: FailedAssertion("!(!((&RegisteredSnapshots)->ph_root == ((void*)0)))", File: "snapmgr.c", Line: 677) Ick. I

Re: [HACKERS] Assertion failure when streaming logical changes

2015-02-10 Thread Andres Freund
On 2015-02-10 22:06:34 +0900, Michael Paquier wrote: > On Tue, Feb 10, 2015 at 9:46 PM, Andres Freund > wrote: > > > Yea, it really looks like the above commit is to "blame". The new xmin > > tracking infrastructure doesn't know about the historical snapshot... > > > > I think that we need a bet

Re: [HACKERS] Assertion failure when streaming logical changes

2015-02-10 Thread Michael Paquier
On Tue, Feb 10, 2015 at 9:46 PM, Andres Freund wrote: > Yea, it really looks like the above commit is to "blame". The new xmin > tracking infrastructure doesn't know about the historical snapshot... > I think that we need a better regression coverage here... For example, we could add some tap te

Re: [HACKERS] Assertion failure when streaming logical changes

2015-02-10 Thread Andres Freund
Hi, On 2015-02-10 21:20:37 +0900, Michael Paquier wrote: > Using test_decoding on HEAD (cc761b1) I am seeing the following assertion > failure: > TRAP: FailedAssertion("!(!((&RegisteredSnapshots)->ph_root == > ((void*)0)))", File: "snapmgr.c", Line: 677) Ick. I guess a revert of 94028691609f8e148

[HACKERS] Assertion failure when streaming logical changes

2015-02-10 Thread Michael Paquier
Hi all, Using test_decoding on HEAD (cc761b1) I am seeing the following assertion failure: TRAP: FailedAssertion("!(!((&RegisteredSnapshots)->ph_root == ((void*)0)))", File: "snapmgr.c", Line: 677) (lldb) bt * thread #1: tid = 0x, 0x7fff8b246d46 libsystem_kernel.dylib`__kill + 10, stop re