Re: [HACKERS] B-tree "finish incomplete split" bug

2009-02-27 Thread Alvaro Herrera
Tom Lane wrote: > "Heikki Linnakangas" writes: > > The trivial fix is to not call CacheInvalidateRelcache() in recovery > > (patch attached). Another option is to put the check into > > CacheInvalidateRelcache() itself, but in the name of consistency we > > should then put the same check into t

Re: [HACKERS] B-tree "finish incomplete split" bug

2008-06-11 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > The trivial fix is to not call CacheInvalidateRelcache() in recovery > (patch attached). Another option is to put the check into > CacheInvalidateRelcache() itself, but in the name of consistency we > should then put the same check into the othe

[HACKERS] B-tree "finish incomplete split" bug

2008-06-11 Thread Heikki Linnakangas
While testing my xlogutils.c refactoring patch, I bumped into an existing bug in the B-tree code that finishes an incomplete split: btree_xlog_cleanup() calls _bt_insert_parent() to insert the parent pointer. If the split page was the root page, _bt_insert_parent() creates a new root page by c