Re: [HACKERS] BRIN de-summarize ranges

2017-04-01 Thread Alvaro Herrera
Alvaro Herrera wrote: > > However, I found that when calling brin_desummarize_range > > successively, an assertion is failed. It seems to me that it occurs > > when desummarizing a revmap page that is already desummarized. > > You're right, it's broken for that case. Here's a fixed patch. Pushe

Re: [HACKERS] BRIN de-summarize ranges

2017-04-01 Thread Alvaro Herrera
Seki, Eiji wrote: > However, I found that when calling brin_desummarize_range > successively, an assertion is failed. It seems to me that it occurs > when desummarizing a revmap page that is already desummarized. You're right, it's broken for that case. Here's a fixed patch. -- Álvaro Herrera

Re: [HACKERS] BRIN de-summarize ranges

2017-03-22 Thread Seki, Eiji
On 2017-02-28 04:56:43 Alvaro Herrera wrote: > Here's a small patch to make a BRIN page range unsummarized. This is > useful if data has been deleted, and the heap pages are now used for > completely different data. Hi, I tried to apply your patch and use it. Applying and "make check" were succ

Re: [HACKERS] BRIN de-summarize ranges

2017-03-07 Thread Simon Riggs
On 28 February 2017 at 12:56, Alvaro Herrera wrote: > Here's a small patch to make a BRIN page range unsummarized. This is > useful if data has been deleted, and the heap pages are now used for > completely different data. We currently have a manual interface for summarize new values, so it mak

Re: [HACKERS] BRIN de-summarize ranges

2017-02-28 Thread Tom Lane
Alvaro Herrera writes: > Here's a small patch to make a BRIN page range unsummarized. This is > useful if data has been deleted, and the heap pages are now used for > completely different data. This seems remarkably, um, manual. Why shouldn't users expect the system to take care of this for the

[HACKERS] BRIN de-summarize ranges

2017-02-27 Thread Alvaro Herrera
Here's a small patch to make a BRIN page range unsummarized. This is useful if data has been deleted, and the heap pages are now used for completely different data. -- Álvaro Herrera diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index b22563b..fd7c323 100644 --- a/