Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-13 Thread Tom Lane
Peter Eisentraut writes: > On ons, 2011-05-11 at 16:47 -0400, Tom Lane wrote: >> Hm, do you know how to enumerate the available locales on Windows? > EnumSystemLocalesEx() > Reference: > http://msdn.microsoft.com/en-us/library/dd317829(v=vs.85).aspx > Example: http://msdn.microsoft.com/en-us/li

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-11 Thread Tom Lane
Peter Eisentraut writes: > On ons, 2011-05-11 at 16:47 -0400, Tom Lane wrote: >> Hm, do you know how to enumerate the available locales on Windows? > EnumSystemLocalesEx() > Reference: > http://msdn.microsoft.com/en-us/library/dd317829(v=vs.85).aspx > Example: http://msdn.microsoft.com/en-us/li

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-11 Thread Peter Eisentraut
On ons, 2011-05-11 at 16:47 -0400, Tom Lane wrote: > Hm, do you know how to enumerate the available locales on Windows? EnumSystemLocalesEx() Reference: http://msdn.microsoft.com/en-us/library/dd317829(v=vs.85).aspx Example: http://msdn.microsoft.com/en-us/library/dd319091(v=vs.85).aspx As you

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-11 Thread Tom Lane
Peter Eisentraut writes: > On tis, 2011-05-10 at 18:05 -0400, Tom Lane wrote: >> The lack of initdb support for getting more-or-less-standard collation >> entries into pg_collation on Windows seems to be the major missing >> piece from here (dunno if Peter is aware of others). If we don't fix >>

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-11 Thread Peter Eisentraut
On tis, 2011-05-10 at 18:05 -0400, Tom Lane wrote: > The lack of initdb support for getting more-or-less-standard collation > entries into pg_collation on Windows seems to be the major missing > piece from here (dunno if Peter is aware of others). If we don't fix > that before release, we're going

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Tom Lane
Peter Eisentraut writes: > I'm all for more test suites, but we should make them as widely > accessible and accessed as possible so that they get maintained. Yeah. My preference would really be to push something like collate.linux.utf8 into the standard regression tests, but we'd first have to g

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Peter Eisentraut
On tis, 2011-05-10 at 15:48 -0400, Robert Haas wrote: > On Tue, May 10, 2011 at 3:09 PM, Peter Eisentraut wrote: > > Well, the result of "people don't always run them" is the rest of > > src/test/. How much of that stuff even works anymore? > > I don't know. But I'm not sure I see your point.

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Peter Eisentraut
On tis, 2011-05-10 at 15:17 -0400, Tom Lane wrote: > Well, that would be great, but the "someone" is not going to be me; > I don't do Windows. Yeah, me neither. At least not for this release. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscrip

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Robert Haas
On Tue, May 10, 2011 at 3:09 PM, Peter Eisentraut wrote: > On mån, 2011-05-09 at 10:56 -0400, Robert Haas wrote: >> I'm just shooting from the hip here, but maybe we could have a >> separate (probably smaller) set of tests that are only designed to >> work in a limited range of locales and/or enco

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Tom Lane
Peter Eisentraut writes: > On mån, 2011-05-09 at 12:42 -0400, Tom Lane wrote: >> The problem we'd have is that there's no way (at present) to make such >> a test pass on every platform. Windows has its own set of locale names >> (which initdb fails to install as collations anyway) and we also ha

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Peter Eisentraut
On mån, 2011-05-09 at 12:42 -0400, Tom Lane wrote: > The problem we'd have is that there's no way (at present) to make such > a test pass on every platform. Windows has its own set of locale names > (which initdb fails to install as collations anyway) and we also have > the problem that OS X can b

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-10 Thread Peter Eisentraut
On mån, 2011-05-09 at 10:56 -0400, Robert Haas wrote: > I'm just shooting from the hip here, but maybe we could have a > separate (probably smaller) set of tests that are only designed to > work in a limited range of locales and/or encodings. I'm really > pleased that we now have the src/test/isol

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-09 Thread Kevin Grittner
Tom Lane wrote: > I am thinking about a new target "installcheck-collations" in > src/test/regress/GNUmakefile that creates a UTF8-encoding database > and runs a different test schedule than the regular tests. I don't know the best way to do this (or how many people agree we should), but I fou

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-09 Thread Tom Lane
Robert Haas writes: > On Mon, May 9, 2011 at 10:39 AM, Tom Lane wrote: >> No objection here, but how will we do that?  The regression tests are >> designed to work in any locale/encoding, and would become significantly >> less useful if they weren't. > I'm just shooting from the hip here, but ma

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-09 Thread Robert Haas
On Mon, May 9, 2011 at 10:39 AM, Tom Lane wrote: > Robert Haas writes: >> Well, since any problems in this are are going to bite us eventually >> in 9.0+ even without any further action on our part, maybe it would be >> wise to think up something we could add to the regression tests.  That >> wou

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-09 Thread Tom Lane
Robert Haas writes: > Well, since any problems in this are are going to bite us eventually > in 9.0+ even without any further action on our part, maybe it would be > wise to think up something we could add to the regression tests. That > would give us some immediate feedback from the buildfarm, a

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-09 Thread Robert Haas
On Sat, May 7, 2011 at 12:41 PM, Tom Lane wrote: > Robert Haas writes: >> On the flip side, the risk of it flat-out blowing up seems pretty >> small.  For someone to invent their own version of wchar_t that uses >> something other than Unicode code points would be pretty much pure >> masochism, w

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-07 Thread Tom Lane
Robert Haas writes: > On the flip side, the risk of it flat-out blowing up seems pretty > small. For someone to invent their own version of wchar_t that uses > something other than Unicode code points would be pretty much pure > masochism, wouldn't it? Well, no, that's not clear. The C standard

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-06 Thread Robert Haas
On Fri, May 6, 2011 at 9:22 AM, Andres Freund wrote: > On Friday, May 06, 2011 04:30:01 AM Robert Haas wrote: >> On Thu, May 5, 2011 at 5:21 AM, Andres Freund wrote: >> > In my opinion this is actually a bug in < 9.0. As its a (imo) low impact >> > fix thats constrained to two files it seems sens

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-06 Thread Andres Freund
On Friday, May 06, 2011 04:30:01 AM Robert Haas wrote: > On Thu, May 5, 2011 at 5:21 AM, Andres Freund wrote: > > In my opinion this is actually a bug in < 9.0. As its a (imo) low impact > > fix thats constrained to two files it seems sensible to backpatch it now > > that the solution has proven i

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-05 Thread Robert Haas
On Thu, May 5, 2011 at 5:21 AM, Andres Freund wrote: > In my opinion this is actually a bug in < 9.0. As its a (imo) low impact fix > thats constrained to two files it seems sensible to backpatch it now that the > solution has proven itself in the field? > > The issue is hard to find and has come

Re: [HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-05 Thread Tom Lane
Andres Freund writes: > In my opinion this is actually a bug in < 9.0. As its a (imo) low impact fix > thats constrained to two files it seems sensible to backpatch it now that the > solution has proven itself in the field? FWIW, I still don't trust that patch a lot (and I was the one who wrote

[HACKERS] Backpatching of "Teach the regular expression functions to do case-insensitive matching"

2011-05-05 Thread Andres Freund
Hi, In my opinion this is actually a bug in < 9.0. As its a (imo) low impact fix thats constrained to two files it seems sensible to backpatch it now that the solution has proven itself in the field? The issue is hard to find and has come up several times in the field. And it has been slightl