Tom Lane wrote:
Greg Stark writes:
i like the idea of just have a separate pair of probes for table
extension. I bet there are people who would actually like to see that
alone sometimes too.
After further thought I concluded that the best solution for this is to
add the isExtend flag
Just returned from vacation ...
Tom Lane wrote:
I notice that we have in md.c
TRACE_POSTGRESQL_SMGR_MD_READ_DONE(forknum, blocknum, reln->smgr_rnode.spcNode,
reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode, relpath(reln->smgr_rnode,
forknum), nbytes, BLCKSZ);
TRACE_POSTGRES
Greg Stark writes:
> On Wed, Mar 11, 2009 at 11:50 PM, Tom Lane wrote:
>> Furthermore, an isExtend call doesn't actually do a read(), so lumping
>> them together with regular reads doesn't seem like quite the right thing
>> for performance measurement purposes anyway. Maybe we actually ought to
On Wed, Mar 11, 2009 at 11:50 PM, Tom Lane wrote:
> Furthermore, an isExtend call doesn't actually do a read(), so lumping
> them together with regular reads doesn't seem like quite the right thing
> for performance measurement purposes anyway. Maybe we actually ought to
> have different probes
I wrote:
> Seems that we need to have been quality-checking the dtrace patches
> a bit more carefully.
I went over all the existing dtrace probe calls and fixed what seemed
clearly bogus, but there was one issue that seems like a bit of a
judgement call. In ReadBuffer_common() we have
isExte
I notice that we have in md.c
TRACE_POSTGRESQL_SMGR_MD_READ_DONE(forknum, blocknum,
reln->smgr_rnode.spcNode, reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode,
relpath(reln->smgr_rnode, forknum), nbytes, BLCKSZ);
TRACE_POSTGRESQL_SMGR_MD_WRITE_DONE(forknum, blocknum,
reln->smg
