Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-09 Thread Tom Lane
ITAGAKI Takahiro itagaki.takah...@oss.ntt.co.jp writes: I think there two independent items here: [1] Should we add those statistics to pg_stat_statements or not? [2] Should we add those statistics to EXPLAIN ANALYZE or not? I wanted to have [1] and proposed it, but it is rejected from

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-09 Thread Gregory Stark
Tom Lane t...@sss.pgh.pa.us writes: No, I think you misunderstood me entirely. The reason that I rejected those parts of the patch is that I think the statistics that are available are wrong/useless. If the bufmgr.c counters were really good for something they'd have been exposed long since

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread Bruce Momjian
What did you want done with this patch? It is unlikely we want to see those counters by default, and we have had little demand for them. --- Vladimir Sitnikov wrote: Hi all, Here is a patch that adds buffer pool

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: What did you want done with this patch? It is unlikely we want to see those counters by default, and we have had little demand for them. Here is a patch that adds buffer pool statistics to the explain analyze output revealing the number of buffer pages

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: What did you want done with this patch? It is unlikely we want to see those counters by default, and we have had little demand for them. Here is a patch that adds buffer pool statistics to the explain analyze output revealing the

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread Alvaro Herrera
Bruce Momjian escribió: What did you want done with this patch? It is unlikely we want to see those counters by default, and we have had little demand for them. If there are two people who need them bad enough to have written a patch for them, this seems to say that there is a certain demand

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread Alex Hunsaker
On Thu, Jan 8, 2009 at 17:30, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: What did you want done with this patch? It is unlikely we want to see those counters by default, and we have had little demand for them. Here is a patch that adds

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread ITAGAKI Takahiro
Alex Hunsaker bada...@gmail.com wrote: What did you want done with this patch? It is unlikely we want to see those counters by default, and we have had little demand for them. This was already rejected in connection with pg_stat_statements, no? You know, I thought we discussed it

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2008-11-01 Thread Vladimir Sitnikov
Hi all, Here is a patch that adds buffer pool statistics to the explain analyze output revealing the number of buffer pages hit at each and every execution step. It uses counters from storage/buffer/bufmgr.c (I believe all that counters are relevant for investigation of query performance).

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2008-10-12 Thread ITAGAKI Takahiro
Vladimir Sitnikov [EMAIL PROTECTED] wrote: I've tried to use ReadBufferCount and friends from storage\buffer\buf_init.c, however it is showing zeroes for some unknown yet reason. Hope, there is no fundamental problem behind. I think those vairables are hard to use and have no reliability for

[HACKERS] Buffer pool statistics in Explain Analyze

2008-10-11 Thread Vladimir Sitnikov
Hi, I believe it makes sense adding some more details to explain analyze output like the number of pages read/written. This will allow one to understand the workload the query puts on the server making it easier to tune queries, choose the best indices, etc. As far as I understand, this patch is

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2008-10-11 Thread Gregory Stark
Vladimir Sitnikov [EMAIL PROTECTED] writes: Hi, I believe it makes sense adding some more details to explain analyze output like the number of pages read/written. This will allow one to understand the workload the query puts on the server making it easier to tune queries, choose the best

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2008-10-11 Thread Vladimir Sitnikov
The main problem I ran into was that the instrumentation nodes currently are nested. That is, all the time for your children counts against you as well. Is that what we want for I/O costs? As for me, I see nothing wrong with such costs model. I think it is good to know stuff like the whole