Re: [HACKERS] Bug in abbreviated keys abort handling (found with amcheck)

2016-08-22 Thread Peter Geoghegan
On Mon, Aug 22, 2016 at 12:34 PM, Robert Haas wrote: > Ugh, that sucks. Thanks for the report and patch. Committed and > back-patched to 9.5. Thanks. Within Heroku, there is a lot of enthusiasm for the idea of sharing hard data about the prevalence of problems like this. I hope to be able to sh

Re: [HACKERS] Bug in abbreviated keys abort handling (found with amcheck)

2016-08-22 Thread Robert Haas
On Fri, Aug 19, 2016 at 6:07 PM, Peter Geoghegan wrote: > I found another bug as a result of using amcheck on Heroku customer > databases. This time, the bug is in core Postgres. It's one of mine. > > There was a thinko in tuplesort's abbreviation abort logic, causing > certain SortTuples to be sp

[HACKERS] Bug in abbreviated keys abort handling (found with amcheck)

2016-08-19 Thread Peter Geoghegan
I found another bug as a result of using amcheck on Heroku customer databases. This time, the bug is in core Postgres. It's one of mine. There was a thinko in tuplesort's abbreviation abort logic, causing certain SortTuples to be spuriously marked NULL (and so, subsequently sorted as a NULL tuple,