Re: [HACKERS] Bug in pg_hba.conf or pg_basebackup concerning replication connections

2011-04-09 Thread Josh Berkus
> That's a 2000 line patch that looks like it's out of the question now. > But I think this should fix Josh's immediate problem if we want to do it: I have confirmed that Andrew's patch works. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (

Re: [HACKERS] Bug in pg_hba.conf or pg_basebackup concerning replication connections

2011-04-09 Thread Andrew Dunstan
On 04/09/2011 07:11 PM, Andrew Dunstan wrote: Incidentally, are walsenders supposed to be able to match any db name other than 'replication'? If not, I think we have a bug in check_db(), which is probably missing an "else return false;" in the amwalsender branch. Sorry, I misread the

Re: [HACKERS] Bug in pg_hba.conf or pg_basebackup concerning replication connections

2011-04-09 Thread Andrew Dunstan
On 04/09/2011 03:18 PM, Brendan Jurd wrote: On 10 April 2011 04:23, Joshua Berkus wrote: If I have the following line in pg_hba.conf: hostreplication replication all md5 pg_basebackup -x -v -P -h master1 -U replication -D $PGDATA pg_basebackup: could

Re: [HACKERS] Bug in pg_hba.conf or pg_basebackup concerning replication connections

2011-04-09 Thread Josh Berkus
> Welcome to the wonderful world of keywords in hba not being specific > to fields. I encountered this problem myself back in Oct 2010 [1] and > predicted that it would bite other users. You've been kind enough to > validate that prediction. I submitted a WIP patch aimed at fixing it > just ove

Re: [HACKERS] Bug in pg_hba.conf or pg_basebackup concerning replication connections

2011-04-09 Thread Brendan Jurd
On 10 April 2011 04:23, Joshua Berkus wrote: > If I have the following line in pg_hba.conf: > > host    replication     replication             all                     md5 > > pg_basebackup -x -v -P -h master1 -U replication -D $PGDATA > pg_basebackup: could not connect to server: FATAL:  no pg_hb

[HACKERS] Bug in pg_hba.conf or pg_basebackup concerning replication connections

2011-04-09 Thread Joshua Berkus
All, If I have the following line in pg_hba.conf: hostreplication replication all md5 pg_basebackup -x -v -P -h master1 -U replication -D $PGDATA pg_basebackup: could not connect to server: FATAL: no pg_hba.conf entry for replication connection from host