Re: [HACKERS] Bug in two-phase transaction recovery

2016-09-09 Thread Simon Riggs
On 8 September 2016 at 11:18, Simon Riggs wrote: > On 8 September 2016 at 07:43, Michael Paquier > wrote: >> On Wed, Sep 7, 2016 at 10:48 PM, Stas Kelvich >> wrote: >>> Some time ago two-phase state file format was changed to have variable size >>> GID, >>> but several places that read that f

Re: [HACKERS] Bug in two-phase transaction recovery

2016-09-08 Thread Simon Riggs
On 8 September 2016 at 07:43, Michael Paquier wrote: > On Wed, Sep 7, 2016 at 10:48 PM, Stas Kelvich > wrote: >> Some time ago two-phase state file format was changed to have variable size >> GID, >> but several places that read that files were not updated to use new offsets. >> Problem >> exi

Re: [HACKERS] Bug in two-phase transaction recovery

2016-09-08 Thread Pavan Deolasee
On Thu, Sep 8, 2016 at 12:13 PM, Michael Paquier wrote: > On Wed, Sep 7, 2016 at 10:48 PM, Stas Kelvich > wrote: > > Some time ago two-phase state file format was changed to have variable > size GID, > > but several places that read that files were not updated to use new > offsets. Problem > > e

Re: [HACKERS] Bug in two-phase transaction recovery

2016-09-07 Thread Michael Paquier
On Wed, Sep 7, 2016 at 10:48 PM, Stas Kelvich wrote: > Some time ago two-phase state file format was changed to have variable size > GID, > but several places that read that files were not updated to use new offsets. > Problem > exists in master and 9.6 and can be reproduced on prepared transact

[HACKERS] Bug in two-phase transaction recovery

2016-09-07 Thread Stas Kelvich
Hello. Some time ago two-phase state file format was changed to have variable size GID, but several places that read that files were not updated to use new offsets. Problem exists in master and 9.6 and can be reproduced on prepared transactions with savepoints. For example: create table t(id int