Re: [HACKERS] Build failure on thrips

2017-08-26 Thread Michael Meskes
> woodlouse does not do ecpg-check, and Tom is right anyway. I need to > get a large sign nailed to my forehead that says "Postgres is C, and > declarations must come first." I didn't notice either. I guess /me is getting rusty, sigh. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Mich

Re: [HACKERS] Build failure on thrips

2017-08-26 Thread Michael Meskes
> Unless someone has a better idea, I'd suggest working around > that like so: > > #ifdef WIN32 > #ifdef _MSC_VER/* requires MSVC */ >    _configthreadlocale(_ENABLE_PER_THREAD_LOCALE); > #endif > #endif Let's try, committed, thanks again Tom. Michael -- Michael Meskes Michael a

Re: [HACKERS] Build failure on thrips

2017-08-26 Thread Christian Ullrich
* Michael Meskes wrote: >> It's not just thrips. Of the Windows machines that have reported in >> since >> that commit, only currawong and baiji passed. Although lorikeet, >> woodlouse, bowerbird, and brolga are showing green, this proves >> nothing >> because they're all configured to skip the

Re: [HACKERS] Build failure on thrips

2017-08-26 Thread Michael Meskes
> It's not just thrips.  Of the Windows machines that have reported in > since > that commit, only currawong and baiji passed.  Although lorikeet, > woodlouse, bowerbird, and brolga are showing green, this proves > nothing > because they're all configured to skip the ecpg check (... I wonder > why)

Re: [HACKERS] Build failure on thrips

2017-08-26 Thread Tom Lane
I wrote: > thrips is showing some weird syntax errors that I suspect mean it's > misinterpreting "_configthreadlocale(_ENABLE_PER_THREAD_LOCALE);" > as a declaration. Actually, looking closer, isn't the problem that you've stuck a function call into the midst of declarations? Some compilers will

Re: [HACKERS] Build failure on thrips

2017-08-26 Thread Tom Lane
Michael Meskes writes: > The bug fix I committed for fixing setlocale in ECPG test cases on Windows > seems to work nicely on all buildfarm animals except thrips. Could anyone with > access to a similar systems please check what's going on or send the > precompiled file that creates the compilatio

[HACKERS] Build failure on thrips

2017-08-26 Thread Michael Meskes
The bug fix I committed for fixing setlocale in ECPG test cases on Windows seems to work nicely on all buildfarm animals except thrips. Could anyone with access to a similar systems please check what's going on or send the precompiled file that creates the compilation errors? Thanks. Michael --