Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-07 Thread Michael Paquier
On Wed, Jun 8, 2016 at 7:06 AM, Alvaro Herrera wrote: > Michael Paquier wrote: >> On Thu, Jun 2, 2016 at 3:42 PM, Michael Paquier >> wrote: >> > On Thu, Jun 2, 2016 at 1:00 PM, Michael Paquier >> > wrote: >> >> I

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-07 Thread Alvaro Herrera
Michael Paquier wrote: > On Thu, Jun 2, 2016 at 3:42 PM, Michael Paquier > wrote: > > On Thu, Jun 2, 2016 at 1:00 PM, Michael Paquier > > wrote: > >> I have added an open item for 9.6 regarding this patch, that would be > >> good to complete

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-06 Thread Michael Paquier
On Tue, Jun 7, 2016 at 7:35 AM, Alvaro Herrera wrote: > In looking at the DROP ACCESS METHOD completion I noticed that the > words_after_create gadget is a bit buggy: for things with more than one > word in the thing name (such as MATERIALIZED VIEW, USER MAPPING FOR, >

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-06 Thread Alvaro Herrera
Michael Paquier wrote: > On Thu, Jun 2, 2016 at 3:42 PM, Michael Paquier > wrote: > > On Thu, Jun 2, 2016 at 1:00 PM, Michael Paquier > > wrote: > >> I have added an open item for 9.6 regarding this patch, that would be > >> good to complete

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-06 Thread Alvaro Herrera
Noah Misch wrote: > The above-described topic is currently a PostgreSQL 9.6 open item. Álvaro, > since you committed the patch believed to have created it, you own this open > item. If some other commit is more relevant or if this does not belong as a > 9.6 open item, please let us know.

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-04 Thread Noah Misch
On Thu, Jun 02, 2016 at 04:00:33PM +0900, Michael Paquier wrote: > On Thu, Jun 2, 2016 at 3:42 PM, Michael Paquier > wrote: > > On Thu, Jun 2, 2016 at 1:00 PM, Michael Paquier > > wrote: > >> I have added an open item for 9.6 regarding this

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-02 Thread Michael Paquier
On Thu, Jun 2, 2016 at 3:42 PM, Michael Paquier wrote: > On Thu, Jun 2, 2016 at 1:00 PM, Michael Paquier > wrote: >> I have added an open item for 9.6 regarding this patch, that would be >> good to complete this work in this release for

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-02 Thread Michael Paquier
On Thu, Jun 2, 2016 at 1:00 PM, Michael Paquier wrote: > I have added an open item for 9.6 regarding this patch, that would be > good to complete this work in this release for consistency with the > other objects. Doh. I forgot to update psql --help. -- Michael From

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-01 Thread Michael Paquier
On Wed, Jun 1, 2016 at 8:25 PM, Teodor Sigaev wrote: As far as I can see, COMMENT ON has no support for access methods. Wouldn't we want to add it as it is created by a command? On top of that, perhaps we could have a backslash command in psql to list the

Re: [HACKERS] COMMENT ON, psql and access methods

2016-06-01 Thread Teodor Sigaev
As far as I can see, COMMENT ON has no support for access methods. Wouldn't we want to add it as it is created by a command? On top of that, perhaps we could have a backslash command in psql to list the supported access methods, like \dam[S]? The system methods would be in this case all the

Re: [HACKERS] COMMENT ON, psql and access methods

2016-05-31 Thread Michael Paquier
On Wed, Jun 1, 2016 at 4:52 AM, Robert Haas wrote: > On Fri, May 27, 2016 at 7:53 AM, Michael Paquier > wrote: >> As far as I can see, COMMENT ON has no support for access methods. >> Wouldn't we want to add it as it is created by a command? On

Re: [HACKERS] COMMENT ON, psql and access methods

2016-05-31 Thread Robert Haas
On Fri, May 27, 2016 at 7:53 AM, Michael Paquier wrote: > As far as I can see, COMMENT ON has no support for access methods. > Wouldn't we want to add it as it is created by a command? On top of > that, perhaps we could have a backslash command in psql to list the >

Re: [HACKERS] COMMENT ON, psql and access methods

2016-05-27 Thread Tom Lane
Michael Paquier writes: > As far as I can see, COMMENT ON has no support for access methods. > Wouldn't we want to add it as it is created by a command? On top of > that, perhaps we could have a backslash command in psql to list the > supported access methods, like

[HACKERS] COMMENT ON, psql and access methods

2016-05-27 Thread Michael Paquier
Hi all, As far as I can see, COMMENT ON has no support for access methods. Wouldn't we want to add it as it is created by a command? On top of that, perhaps we could have a backslash command in psql to list the supported access methods, like \dam[S]? The system methods would be in this case all