Re: [HACKERS] Change in HEAP_NEWPAGE logging makes diagnosis harder

2014-11-24 Thread Heikki Linnakangas
On 11/14/2014 10:17 AM, Heikki Linnakangas wrote: On 10/30/2014 04:12 PM, Andres Freund wrote: Hi, I've just once more looked at the WAL stream ans was briefly confused about all the XLOG_FPI records. Since 54685338e3 log_newpage/log_newpage_buffer and XLogSaveBufferForHint() use the same WAL r

Re: [HACKERS] Change in HEAP_NEWPAGE logging makes diagnosis harder

2014-11-14 Thread Heikki Linnakangas
On 10/30/2014 04:12 PM, Andres Freund wrote: Hi, I've just once more looked at the WAL stream ans was briefly confused about all the XLOG_FPI records. Since 54685338e3 log_newpage/log_newpage_buffer and XLogSaveBufferForHint() use the same WAL record. I personally find that a bad idea because th

[HACKERS] Change in HEAP_NEWPAGE logging makes diagnosis harder

2014-10-30 Thread Andres Freund
Hi, I've just once more looked at the WAL stream ans was briefly confused about all the XLOG_FPI records. Since 54685338e3 log_newpage/log_newpage_buffer and XLogSaveBufferForHint() use the same WAL record. I personally find that a bad idea because they're used in quite different situations. Can