Re: [HACKERS] Changes to stringinfo.c

2013-10-26 Thread David Rowley
On Sun, Oct 27, 2013 at 3:04 AM, Tom Lane wrote: > David Rowley writes: > > I'm just looking at the changed code in commit > > 3147acd63e0135aff9a6c4b01d861251925d97d9 and I'm wondering if we should > > perhaps test the performance of this before assuming too much that it is > an > > improvement

Re: [HACKERS] Changes to stringinfo.c

2013-10-26 Thread Tom Lane
David Rowley writes: > I'm just looking at the changed code in commit > 3147acd63e0135aff9a6c4b01d861251925d97d9 and I'm wondering if we should > perhaps test the performance of this before assuming too much that it is an > improvement. I'm a bit concerned that now if there is not enough space in

[HACKERS] Changes to stringinfo.c

2013-10-25 Thread David Rowley
Hi, I'm just looking at the changed code in commit 3147acd63e0135aff9a6c4b01d861251925d97d9 and I'm wondering if we should perhaps test the performance of this before assuming too much that it is an improvement. I'm a bit concerned that now if there is not enough space in the buffer that we only n