Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Andres Freund
On 2014-03-17 09:14:51 -0400, Robert Haas wrote: > On Mon, Mar 17, 2014 at 8:58 AM, Andres Freund wrote: > > On 2014-03-17 08:00:22 -0400, Robert Haas wrote: > >> On Mon, Mar 17, 2014 at 7:27 AM, Andres Freund > >> wrote: > >> >> - There doesn't seem to be any provision for this tool to ever swi

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Andres Freund
On 2014-03-17 09:13:38 -0400, Robert Haas wrote: > On Mon, Mar 17, 2014 at 8:29 AM, Andres Freund wrote: > >> Perhaps there could be a switch for an fsync interval, or something > >> like that. The default could be, say, to fsync every 10 seconds. And > >> if you want to change it, then go ahead

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Robert Haas
On Mon, Mar 17, 2014 at 8:58 AM, Andres Freund wrote: > On 2014-03-17 08:00:22 -0400, Robert Haas wrote: >> On Mon, Mar 17, 2014 at 7:27 AM, Andres Freund >> wrote: >> >> - There doesn't seem to be any provision for this tool to ever switch >> >> from one output file to the next. That seems lik

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Robert Haas
On Mon, Mar 17, 2014 at 8:29 AM, Andres Freund wrote: >> Perhaps there could be a switch for an fsync interval, or something >> like that. The default could be, say, to fsync every 10 seconds. And >> if you want to change it, then go ahead; 0 disables. Writing to >> standard output would be doc

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Andres Freund
On 2014-03-17 08:00:22 -0400, Robert Haas wrote: > On Mon, Mar 17, 2014 at 7:27 AM, Andres Freund wrote: > >> - There doesn't seem to be any provision for this tool to ever switch > >> from one output file to the next. That seems like a practical need. > >> One idea would be to have it respond to

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Andres Freund
On 2014-03-17 08:00:22 -0400, Robert Haas wrote: > > Yea. The reason it reports the flush position is that it allows to test > > sync rep. I don't think other usecases will appreciate frequent > > fsyncs... Maybe make it optional? > > Well, as I'm sure you recognize, if you're actually trying to b

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Robert Haas
On Mon, Mar 17, 2014 at 7:27 AM, Andres Freund wrote: >> - There doesn't seem to be any provision for this tool to ever switch >> from one output file to the next. That seems like a practical need. >> One idea would be to have it respond to SIGHUP by reopening the >> originally-named output file.

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Andres Freund
On 2014-03-17 06:55:28 -0400, Robert Haas wrote: > On Wed, Mar 12, 2014 at 2:06 PM, Andres Freund wrote: > > Attached are the collected remaining patches. The docs might need > > further additions, but it seems better to add them now. > > A few questions about pg_recvlogical: > > - There doesn't

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-17 Thread Robert Haas
On Wed, Mar 12, 2014 at 2:06 PM, Andres Freund wrote: > Attached are the collected remaining patches. The docs might need > further additions, but it seems better to add them now. A few questions about pg_recvlogical: - There doesn't seem to be any provision for this tool to ever switch from one

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Josh Berkus
On 03/10/2014 02:08 PM, Robert Haas wrote: > On Mon, Mar 10, 2014 at 4:55 PM, Josh Berkus wrote: >> Yeah, that's my thoughts. Although I might wait for recvlogical. Will >> put documentation wordsmithing on my todo list once Andres commits. > > Is this your way of announcing that Andres is gett

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Alvaro Herrera
Robert Haas escribió: > On Mon, Mar 10, 2014 at 3:33 PM, Alvaro Herrera > wrote: > > Robert Haas escribió: > >> I've committed this patch now with a few further tweaks, leaving this > >> issue unaddressed. It may well be something that needs improvement, > >> but I don't think it's a big enough i

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Robert Haas
On Mon, Mar 10, 2014 at 4:55 PM, Josh Berkus wrote: > On 03/10/2014 12:46 PM, Robert Haas wrote: >> On Mon, Mar 10, 2014 at 3:38 PM, Josh Berkus wrote: >>> On 03/10/2014 11:54 AM, Robert Haas wrote: I've committed this patch now with a few further tweaks, leaving this issue unaddressed.

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Josh Berkus
On 03/10/2014 12:46 PM, Robert Haas wrote: > On Mon, Mar 10, 2014 at 3:38 PM, Josh Berkus wrote: >> On 03/10/2014 11:54 AM, Robert Haas wrote: >>> I've committed this patch now with a few further tweaks, leaving this >>> issue unaddressed. It may well be something that needs improvement, >>> but

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Robert Haas
On Mon, Mar 10, 2014 at 3:38 PM, Josh Berkus wrote: > On 03/10/2014 11:54 AM, Robert Haas wrote: >> I've committed this patch now with a few further tweaks, leaving this >> issue unaddressed. It may well be something that needs improvement, >> but I don't think it's a big enough issue to justify

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Andres Freund
On 2014-03-10 12:38:42 -0700, Josh Berkus wrote: > On 03/10/2014 11:54 AM, Robert Haas wrote: > > I've committed this patch now with a few further tweaks, leaving this > > issue unaddressed. It may well be something that needs improvement, > > but I don't think it's a big enough issue to justify h

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Josh Berkus
On 03/10/2014 11:54 AM, Robert Haas wrote: > I've committed this patch now with a few further tweaks, leaving this > issue unaddressed. It may well be something that needs improvement, > but I don't think it's a big enough issue to justify holding back a > commit. Wait, does this mean Changesets

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Andres Freund
Hi, On 2014-03-10 16:33:33 -0300, Alvaro Herrera wrote: > Robert Haas escribió: > > I've committed this patch now with a few further tweaks, leaving this > > issue unaddressed. It may well be something that needs improvement, > > but I don't think it's a big enough issue to justify holding back a

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Robert Haas
On Mon, Mar 10, 2014 at 3:33 PM, Alvaro Herrera wrote: > Robert Haas escribió: >> I've committed this patch now with a few further tweaks, leaving this >> issue unaddressed. It may well be something that needs improvement, >> but I don't think it's a big enough issue to justify holding back a >>

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Alvaro Herrera
Robert Haas escribió: > I've committed this patch now with a few further tweaks, leaving this > issue unaddressed. It may well be something that needs improvement, > but I don't think it's a big enough issue to justify holding back a > commit. Hmm, is the buildfarm exercising any of this? -- Á

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-10 Thread Robert Haas
On Fri, Mar 7, 2014 at 7:44 AM, Andres Freund wrote: > I've attached a new version of the walsender patch. It's been rebased > ontop of Heikki's latest commit to walsender.c. I've changed a fair bit > of stuff: > * The sleeptime is now computed to sleep until we either need to send a > keepalive

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-07 Thread Andres Freund
On 2014-03-07 10:17:21 -0300, Alvaro Herrera wrote: > Andres Freund escribió: > > > fprintf(stderr, > > - _("%s: could not identify system: got > > %d rows and %d fields, expected %d rows and %d fields\n"), > > -

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-07 Thread Alvaro Herrera
Andres Freund escribió: > fprintf(stderr, > - _("%s: could not identify system: got > %d rows and %d fields, expected %d rows and %d fields\n"), > - progname, PQntuples(res), > PQnfields(res), 1, 3); >

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-07 Thread Andres Freund
Hi, On 2014-03-05 23:20:57 +0100, Andres Freund wrote: > On 2014-03-05 17:05:24 -0500, Robert Haas wrote: > > > I very much dislike having the three different event loops, but it's > > > pretty much forced by the design of the xlogreader. "My" xlogreader > > > version didn't block when it neeeded

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-05 Thread Andres Freund
On 2014-03-05 17:05:24 -0500, Robert Haas wrote: > > I very much dislike having the three different event loops, but it's > > pretty much forced by the design of the xlogreader. "My" xlogreader > > version didn't block when it neeeded to wait for WAL but just returned > > "need input/output", but w

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-05 Thread Robert Haas
On Wed, Mar 5, 2014 at 3:04 PM, Andres Freund wrote: > Hi, > > On 2014-03-05 13:49:23 -0500, Robert Haas wrote: >> PLEASE stop using a comma to join two independent thoughts. > > Ok. I'll try. > > Is this a personal preference, or a general rule? There seems to be a > fair amount of comments in pg

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-05 Thread Andres Freund
Hi, On 2014-03-05 13:49:23 -0500, Robert Haas wrote: > PLEASE stop using a comma to join two independent thoughts. Ok. I'll try. Is this a personal preference, or a general rule? There seems to be a fair amount of comments in pg doing so? > This patch still treats "allow a walsender to connect

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-05 Thread Robert Haas
On Wed, Mar 5, 2014 at 1:57 PM, Josh Berkus wrote: > On 03/05/2014 10:49 AM, Robert Haas wrote: >> This patch still treats "allow a walsender to connect to a database" >> as a separate feature from "allow logical replication". I'm not >> convinced that's a good idea. What you're proposing to do i

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-05 Thread Josh Berkus
On 03/05/2014 10:49 AM, Robert Haas wrote: > This patch still treats "allow a walsender to connect to a database" > as a separate feature from "allow logical replication". I'm not > convinced that's a good idea. What you're proposing to do is allow > replication=database in addition to replication

Re: [HACKERS] Changeset Extraction v7.9.1

2014-03-05 Thread Robert Haas
On Tue, Mar 4, 2014 at 6:26 PM, Andres Freund wrote: > On 2014-03-03 16:48:15 -0500, Robert Haas wrote: >> OK, I've committed the 0001 patch, which is the core of this feature, >> with a bit of minor additional hacking. > > Attached are the rebased patches that are remaining. > > Changes: > * mino