Re: [HACKERS] Cleaning up cross-type arithmetic operators

2008-06-18 Thread Simon Riggs
On Tue, 2008-06-17 at 13:29 -0400, Tom Lane wrote: What I'm inclined to do is remove the two % operators, which don't seem likely to be performance-critical Can you discuss what you see as the benefit or trade-offs for doing that? Removing things tends to have major potential for annoying

Re: [HACKERS] Cleaning up cross-type arithmetic operators

2008-06-18 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Tue, 2008-06-17 at 13:29 -0400, Tom Lane wrote: What I'm inclined to do is remove the two % operators, which don't seem likely to be performance-critical Can you discuss what you see as the benefit or trade-offs for doing that? Removing things tends

[HACKERS] Cleaning up cross-type arithmetic operators

2008-06-17 Thread Tom Lane
There was a discussion back here: http://archives.postgresql.org/pgsql-bugs/2008-01/msg00189.php that came to the conclusion that cross-type operators are a bad idea if they don't come in complete sets: if you don't have an exact match to the input types, and there are multiple possible

Re: [HACKERS] Cleaning up cross-type arithmetic operators

2008-06-17 Thread Kenneth Marshall
On Tue, Jun 17, 2008 at 01:29:56PM -0400, Tom Lane wrote: ... What I'm inclined to do is remove the two % operators, which don't seem likely to be performance-critical, and fill in the missing int2-vs-int8 cases for the four basic arithmetic operators. But I could be talked into just nuking