Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-12 Thread KaiGai Kohei
Josh Berkus wrote: Hackers, At this point, almost all patches have been assigned to reviewers. If you submitted a patch and don't get feedback by Saturday, take a look at who's in the "reviewers" column and send them a query. Since I have no way to track when patches are assigned to reviewe

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Andrew Chernow
Josh Berkus wrote: Josh is probably basing that on the long history of discussion/revision cycles. Yep, and that *I* don't understand what the patch does, so I'm not going to turn a newbie reviewer loose on it. Here is a quick overview, there are two parts to the patch: 1. event system T

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Josh Berkus
> Josh is probably basing that on the long history of > discussion/revision cycles. Yep, and that *I* don't understand what the patch does, so I'm not going to turn a newbie reviewer loose on it. -- --Josh Josh Berkus PostgreSQL San Francisco -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Merlin Moncure
On Thu, Sep 11, 2008 at 5:06 PM, Tom Lane <[EMAIL PROTECTED]> wrote: >> The patch looks OK to me as it was the last time I looked at it; maybe >> Tom has more comments, so I decided against just committing it. > > I haven't got round to looking at it in this fest. If anyone else wants > to look it

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Merlin Moncure escribió: >> Alvaro actually performed a review on libpq events. We are waiting on >> his feedback on our changes (based on his review) and the newly >> submitted documentation. I'll update the wiki accordingly. I wasn't >> sure if Alva

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Andrew Chernow
Alvaro Herrera wrote: Actually a minor gripe ... should PQsetvalue be PQsetValue? :-) We were mimicing PQgetvalue, which uses a lowercase 'v'. Is there a preference, none on this end. -- Andrew Chernow eSilo, LLC every bit counts http://www.esilo.com/ -- Sent via pgsql-hackers mailing li

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Alvaro Herrera
Merlin Moncure escribió: > On Thu, Sep 11, 2008 at 1:53 AM, Josh Berkus <[EMAIL PROTECTED]> wrote: > > Some patches have not been assigned to reviewers for various reasons. The > > following weren't assigned because they are complex and really need a > > high-end hacker or committer to take them on

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Merlin Moncure
On Thu, Sep 11, 2008 at 1:53 AM, Josh Berkus <[EMAIL PROTECTED]> wrote: > Some patches have not been assigned to reviewers for various reasons. The > following weren't assigned because they are complex and really need a > high-end hacker or committer to take them on: > > libpq events Alvaro actual

Re: [HACKERS] Commitfest patches mostly assigned ... status

2008-09-11 Thread Tom Lane
Josh Berkus <[EMAIL PROTECTED]> writes: > Also, note that the following patches need performance testing on a > variety of platforms. Everyone should help with this. > GSoC Improved Hash Indexing > posix fadvises > operator restrictivity function for text search > CLUSTER using sort instead of in

[HACKERS] Commitfest patches mostly assigned ... status

2008-09-10 Thread Josh Berkus
Hackers, At this point, almost all patches have been assigned to reviewers. If you submitted a patch and don't get feedback by Saturday, take a look at who's in the "reviewers" column and send them a query. Since I have no way to track when patches are assigned to reviewers, I have no idea i