Re: [HACKERS] Crash when partition column specified twice

2017-04-30 Thread Amit Langote
On 2017/04/29 2:53, Robert Haas wrote: > On Fri, Apr 28, 2017 at 7:23 AM, Beena Emerson > wrote: >> Hello Amit, >> >> The extra n->is_from_type = false; seems to be added by mistake? >> >> @@ -11888,6 +11891,8 @@ TableFuncElement: ColId Typename >> opt_collate_clause >> n->i

Re: [HACKERS] Crash when partition column specified twice

2017-04-28 Thread Robert Haas
On Fri, Apr 28, 2017 at 7:23 AM, Beena Emerson wrote: > Hello Amit, > > The extra n->is_from_type = false; seems to be added by mistake? > > @@ -11888,6 +11891,8 @@ TableFuncElement: ColId Typename > opt_collate_clause > n->is_local = true; > n->is_not_nul

Re: [HACKERS] Crash when partition column specified twice

2017-04-28 Thread Beena Emerson
Hello Amit, The extra n->is_from_type = false; seems to be added by mistake? @@ -11888,6 +11891,8 @@ TableFuncElement: ColId Typename opt_collate_clause n->is_local = true; n->is_not_null = false; n->is_from_type = false; +

Re: [HACKERS] Crash when partition column specified twice

2017-04-27 Thread Amit Langote
On 2017/04/27 12:36, Amit Langote wrote: > Noticed that a crash occurs if a column is specified twice when creating a > partition: > > create table p (a int) partition by list (a); > > -- crashes > create table p1 partition of parent ( > a not null, > a default 1 > ) for values in (1); > > T

[HACKERS] Crash when partition column specified twice

2017-04-26 Thread Amit Langote
Noticed that a crash occurs if a column is specified twice when creating a partition: create table p (a int) partition by list (a); -- crashes create table p1 partition of parent ( a not null, a default 1 ) for values in (1); The logic in MergeAttributes() that merged partition column option