Re: [HACKERS] DSA on 32 bit systems

2017-07-12 Thread Robert Haas
On Wed, Jul 12, 2017 at 7:34 AM, Thomas Munro wrote: > That raises the question of whether we should go further and use a 64 > bit dsa_pointer even on 32 bit systems. In a 32 bit dsa_pointer > build, a single dsa_area is limited to 32 segments of up to 128MB in > size (actually the largest power

[HACKERS] DSA on 32 bit systems

2017-07-12 Thread Thomas Munro
Hi hackers, Commit e8fdbd58fe564a29977f4331cd26f9697d76fc40 introduced fallback atomic u64 support. PG_HAVE_ATOMIC_U64_SUPPORT now always finishes up defined so it is pointless to test for it in dsa.h. Here's a patch to remove the obsolete test and comment. That raises the question of whether w