Re: [HACKERS] Dead Space Map version 2

2007-03-01 Thread Jim C. Nasby
On Wed, Feb 28, 2007 at 04:10:09PM +0900, ITAGAKI Takahiro wrote: Jim C. Nasby [EMAIL PROTECTED] wrote: At some point it might make sense to convert the FSM into a bitmap; that way everything just scales with database size. In the meantime, I'm not sure if it makes sense to tie the FSM

Re: [HACKERS] Dead Space Map version 2

2007-02-28 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: Tom Lane wrote: I'd be happier if the DSM content could be treated as just a hint. If we don't have a frozen state, we can't use the DSM to implement index-only scans. To implement index-only scans, the DSM would have to be

Re: [HACKERS] Dead Space Map version 2

2007-02-28 Thread Takayuki Tsunakawa
Hello, long time no see. This topic looks interesting. I'm enrious of Itagaki-san and others. I can't do now what I want, due to other work that I don't want to do (isn't my boss seeing this?). I wish I could join the community some day and contribute to the development like the great experts

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread Simon Riggs
On Tue, 2007-02-27 at 12:05 +0900, ITAGAKI Takahiro wrote: If we combine this with the HOT patch, pages with HOT tuples are probably marked as UNFROZEN because we don't bother vacuuming HOT tuples. They can be removed incrementally and doesn't require explicit vacuums. Perhaps avoid DSM

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread Simon Riggs
On Tue, 2007-02-27 at 00:55 -0500, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: Yes, DSM would make FSM recovery more important, but I thought it was recoverable now? Or is that only on a clean shutdown? Currently we throw away FSM during any non-clean restart. This is probably

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread ITAGAKI Takahiro
Jim C. Nasby [EMAIL PROTECTED] wrote: If we do UPDATE a tuple, the original page containing the tuple is marked as HIGH and the new page where the updated tuple is placed is marked as LOW. Don't you mean UNFROZEN? No, the new tuples are marked as LOW. I intend to use UNFROZEN and FROZEN

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread ITAGAKI Takahiro
Tom Lane [EMAIL PROTECTED] wrote: Vacuum for XID wraparound would have to hit every page regardless. There is one problem at this point. If we want to guarantee that there are no tuples that XIDs are older than pg_class.relfrozenxid, we must scan all pages for XID wraparound for every vacuums.

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread ITAGAKI Takahiro
Simon Riggs [EMAIL PROTECTED] wrote: If we combine this with the HOT patch, pages with HOT tuples are probably marked as UNFROZEN because we don't bother vacuuming HOT tuples. They can be removed incrementally and doesn't require explicit vacuums. Perhaps avoid DSM entries for HOT

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread Heikki Linnakangas
Tom Lane wrote: The main problem with the levels proposed by Takahiro-san is that any transition from FROZEN to not-FROZEN *must* be exactly recovered, because vacuum will never visit an allegedly frozen page at all. This appears to require WAL-logging DSM state changes, which is a pretty

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread Jim C. Nasby
On Tue, Feb 27, 2007 at 12:55:21AM -0500, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: Yes, DSM would make FSM recovery more important, but I thought it was recoverable now? Or is that only on a clean shutdown? Currently we throw away FSM during any non-clean restart. This is

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread Jim C. Nasby
On Tue, Feb 27, 2007 at 05:38:39PM +0900, ITAGAKI Takahiro wrote: Jim C. Nasby [EMAIL PROTECTED] wrote: If we do UPDATE a tuple, the original page containing the tuple is marked as HIGH and the new page where the updated tuple is placed is marked as LOW. Don't you mean UNFROZEN?

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: Tom Lane wrote: I'd be happier if the DSM content could be treated as just a hint. If we don't have a frozen state, we can't use the DSM to implement index-only scans. To implement index-only scans, the DSM would have to be expected to provide

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread ITAGAKI Takahiro
Jim C. Nasby [EMAIL PROTECTED] wrote: I'd like to add some kind of logical flavors to max_fsm_pages and max_dsm_pages. In the meantime, I'm not sure if it makes sense to tie the FSM size to the DSM size, since each FSM page requires 48x the storage of a DSM page. I think there's also a

Re: [HACKERS] Dead Space Map version 2

2007-02-27 Thread ITAGAKI Takahiro
Jim C. Nasby [EMAIL PROTECTED] wrote: At some point it might make sense to convert the FSM into a bitmap; that way everything just scales with database size. In the meantime, I'm not sure if it makes sense to tie the FSM size to the DSM size, since each FSM page requires 48x the storage of a

[HACKERS] Dead Space Map version 2

2007-02-26 Thread ITAGAKI Takahiro
This is the second proposal for Dead Space Map (DSM). Here is the previous discussion: http://archives.postgresql.org/pgsql-hackers/2006-12/msg01188.php I'll post the next version of the Dead Space Map patch to -patches. I've implemented 2bits/page bitmap and new vacuum commands. Memory

Re: [HACKERS] Dead Space Map version 2

2007-02-26 Thread Jim C. Nasby
On Tue, Feb 27, 2007 at 12:05:57PM +0900, ITAGAKI Takahiro wrote: Each heap pages have 4 states for dead space map; HIGH, LOW, UNFROZEN and FROZEN. VACUUM uses the states to reduce the number of target pages. - HIGH : High priority to vacuum. Maybe many dead tuples in the page. - LOW

Re: [HACKERS] Dead Space Map version 2

2007-02-26 Thread Tom Lane
Jim C. Nasby [EMAIL PROTECTED] writes: Yes, DSM would make FSM recovery more important, but I thought it was recoverable now? Or is that only on a clean shutdown? Currently we throw away FSM during any non-clean restart. This is probably overkill but I'm quite unclear what would be a safe

Re: [HACKERS] Dead Space Map version 2

2007-02-26 Thread Simon Riggs
On Tue, 2007-02-27 at 12:05 +0900, ITAGAKI Takahiro wrote: I think it's better to get DSM and HOT together. DSM is good at complex updated cases but not at heavily updated cases. HOT has opposite aspects, as far as I can see. I think they can cover each other. Very much agreed. I'll be