On 01/28/2015 02:47 AM, Michael Paquier wrote:
On Wed, Jan 28, 2015 at 3:15 AM, Tom Lane wrote:
So I'm fine with taking out both this documentation text and the dead
null-pointer checks; but let's do that all in one patch not piecemeal.
In any case, this is just cosmetic cleanup; there's no act
On Wed, Jan 28, 2015 at 3:15 AM, Tom Lane wrote:
> So I'm fine with taking out both this documentation text and the dead
> null-pointer checks; but let's do that all in one patch not piecemeal.
> In any case, this is just cosmetic cleanup; there's no actual hazard
> here.
Attached is a patch with
Heikki Linnakangas writes:
> I think you are confusing NULL pointers with an SQL NULL.
> gistgetadjusted checks that it's not an SQL NULL (!oldisnull[i]), but it
> does not check if it's a NULL pointer
> (DatumGetPointer(oldentries[i].key) != NULL). The case we're worried
> about is that the v
On 01/21/2015 07:14 AM, Michael Paquier wrote:
Also,
looking at the code of gist, gbt_var_same is called through
gistKeyIsEQ, which is used for an insertion or for a split. The point
is that when doing an insertion, a call to gistgetadjusted is done and
we look if one of the keys is NULL. If one
On Tue, Jan 20, 2015 at 11:38 PM, Tom Lane wrote:
> Michael Paquier writes:
>> Coverity is pointing out $subject, with the following stuff in
>> gbt_var_same():
>> ...
>> As Heikki pointed me out on IM, the lack of crash report in this area,
>> as well as similar coding style in cube/ seem to be
Michael Paquier writes:
> Coverity is pointing out $subject, with the following stuff in gbt_var_same():
> ...
> As Heikki pointed me out on IM, the lack of crash report in this area,
> as well as similar coding style in cube/ seem to be sufficient
> arguments to simply remove those NULL checks in
Hi all,
Coverity is pointing out $subject, with the following stuff in gbt_var_same():
GBT_VARKEY *t1 = (GBT_VARKEY *) DatumGetPointer(d1);
GBT_VARKEY *t2 = (GBT_VARKEY *) DatumGetPointer(d2);
GBT_VARKEY_R r1,
r2;
r1 = gbt_var_key_re
