Re: [HACKERS] Did we forget to unpin buf in function "revmap_physical_extend" ?

2015-09-11 Thread Alvaro Herrera
Jinyu Zhang wrote: > In function "revmap_physical_extend", should we add "ReleaseBuffer(buf);" > between line 438 and 439 ? > 422 else > 423 { > 424 if (needLock) > 425 LockRelationForExtension(irel, ExclusiveLock); > 426 > 427 buf = ReadBuffer(irel, P_N

[HACKERS] Did we forget to unpin buf in function "revmap_physical_extend" ?

2015-09-11 Thread Jinyu Zhang
In function "revmap_physical_extend", should we add "ReleaseBuffer(buf);" between line 438 and 439 ? 422 else 423 { 424 if (needLock) 425 LockRelationForExtension(irel, ExclusiveLock); 426 427 buf = ReadBuffer(irel, P_NEW); 428 if (BufferGetBlock