Itagaki Takahiro writes:
> Thank you for reviewing. An updated patch is attached.
I applied this with some revisions.
I didn't like the fact that error reports for functional indexes came out
with "pg_expression_n" instead of something useful. I tweaked things to
use the pg_get_indexdef code to
"Dickson S. Guedes" wrote:
> Hum, for key names ok, but for values, wouldn't this worse the output when
> it is greater than 512 bytes?
Why do we need to cut values in 512 bytes? It might be generate larger logs
before, but we don't have any limits for length of log messages.
ex) ERROR: ...
Em Tue, 21 Jul 2009 02:07:47 -0300, Itagaki Takahiro
escreveu:
I modified the format logic to use StringInfo and don't cut off the
message in 512 bytes. Key names and values will be never into '...'. I
changed both both report_unique_violation() and ri_ReportViolation().
Hi Takahiro!
Hum,
"Dickson S. Guedes" wrote:
> Hi Takahiro, i'm the reviewer of your patch, and the following are my
> comments about it:
Thank you for reviewing. An updated patch is attached.
> The patch was applied totalty clean to CVS HEAD and compiled in Ubuntu
> 8.04, Ubuntu 8.10 and AIX 5.3, but faile
Em Fri, 03 Apr 2009 04:23:10 -0300, Itagaki Takahiro
escreveu:
Vlad Arkhipov wrote:
Is it possible to print which key value is duplicated when 'Duplicate
key value violates unique constraint' occurs? Foreign key violation
error reports such kind of information.
I think it is not difficult
Itagaki Takahiro writes:
> Vlad Arkhipov wrote:
>> Is it possible to print which key value is duplicated when 'Duplicate
>> key value violates unique constraint' occurs? Foreign key violation
>> error reports such kind of information.
> If no objection, I'd like to submit the patch to the next
Vlad Arkhipov wrote:
> Is it possible to print which key value is duplicated when 'Duplicate
> key value violates unique constraint' occurs? Foreign key violation
> error reports such kind of information.
I think it is not difficult from a technical standpoint.
The attached patch adds DETAIL
Is it possible to print which key value is duplicated when 'Duplicate
key value violates unique constraint' occurs? Foreign key violation
error reports such kind of information.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://ww
