Re: [HACKERS] Enable SSPI on cygwin

2009-07-24 Thread Andrew Dunstan
Reini, the style of this patch has previously been criticized by both Magnus and me. We do not define WIN32 *anywhere* in our sources, and we don't want to start. In fact, IIRC we carefully removed all such code years ago, because it caused us lots of grief. Please find a way to code your

Re: [HACKERS] Enable SSPI on cygwin

2009-07-24 Thread Magnus Hagander
On Fri, Jul 24, 2009 at 23:47, Reini Urban wrote: > Attached is my patch to enable SSPI on cygwin. Is it really such a good idea to keep doing #define WIN32 and #undef WIN32 in multiple places? It seems very fragile to me - we should keep the defines for cygwin and win32 separate. Even if that mea

[HACKERS] Enable SSPI on cygwin

2009-07-24 Thread Reini Urban
Attached is my patch to enable SSPI on cygwin. -- Reini Urban http://phpwiki.org/ http://murbreak.at/ --- origsrc/postgresql-8.4.0/configure.in 2009-06-27 02:14:47.0 +0200 +++ src/postgresql-8.4.0/configure.in 2009-07-02 09:02:25.921875000 +0200 @@ -907,7 +907,11 @@ if test "$with_gssapi