Re: [HACKERS] Error message cleanup

2003-09-26 Thread Peter Eisentraut
Alvaro Herrera writes: > Regarding your message cleanup, I wonder about: > > #: rewrite/rewriteDefine.c:274 > msgid "rules on SELECT rule must have action INSTEAD SELECT" > > Is this really the intended wording? > > #: utils/misc/guc.c:1318 > msgid "log statement generating error at or above this

Re: [HACKERS] Error message cleanup

2003-09-25 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > On Sun, Sep 21, 2003 at 05:37:59PM +0200, Peter Eisentraut wrote: > #: rewrite/rewriteDefine.c:274 > msgid "rules on SELECT rule must have action INSTEAD SELECT" > Is this really the intended wording? Seems like a typo to me too. Maybe "rules ON SELEC

Re: [HACKERS] Error message cleanup

2003-09-25 Thread Alvaro Herrera
On Sun, Sep 21, 2003 at 05:37:59PM +0200, Peter Eisentraut wrote: > I've looked through the messages in the backend and identified some areas > that still deserve some cleanup. Below I list some issues that deserve > some discussion or that deserve being remembered by other developers. Regarding

Re: [HACKERS] Error message cleanup

2003-09-24 Thread Peter Eisentraut
Alvaro Herrera writes: > Are you going to change "relation" to "table"? In most cases that is > the intended meaning. ISTM in some other cases it refers to anything > that can appear in pg_class, but I'm not 100% sure. There are a few cases where it was obvious that only a table could be meant,

Re: [HACKERS] Error message cleanup

2003-09-24 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Are you going to change "relation" to "table"? In most cases that is > the intended meaning. ISTM in some other cases it refers to anything > that can appear in pg_class, but I'm not 100% sure. Quite a lot of the code considers "relation" to mean "any

Re: [HACKERS] Error message cleanup

2003-09-24 Thread Alvaro Herrera
On Sun, Sep 21, 2003 at 05:37:59PM +0200, Peter Eisentraut wrote: > I've looked through the messages in the backend and identified some areas > that still deserve some cleanup. Below I list some issues that deserve > some discussion or that deserve being remembered by other developers. > > id, oi

Re: [HACKERS] Error message cleanup

2003-09-21 Thread Gaetano Mendola
Peter Eisentraut wrote: "transaction block" vs. "BEGIN/END transaction block" -> Both are used, I think the first one is better. I vote for the second one. Regards Gaetano Mendola ---(end of broadcast)--- TIP 7: don't forget to increase your free spa

[HACKERS] Error message cleanup

2003-09-21 Thread Peter Eisentraut
I've looked through the messages in the backend and identified some areas that still deserve some cleanup. Below I list some issues that deserve some discussion or that deserve being remembered by other developers. id, oid, pid-> ID, OID, PID attribute -> column tuple