Re: [HACKERS] Executable files in CVS

2003-11-24 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane writes: Besides, it's a tad odd to see files that are marked group writable but not owner writable. You've got to agree there's not much sense in that. How else are you going to commit files? /usr/bin/cvs is not setuid, Sure, but as long

[HACKERS] Executable files in CVS

2003-11-23 Thread Peter Eisentraut
While people add more executable files to CVS (cf. initdb.c), can we do something about it? -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Bruce Momjian
Peter Eisentraut wrote: While people add more executable files to CVS (cf. initdb.c), can we do something about it? Sure. I logged into the main server machine and cd'ed to CVSROOT. I then when to the src/bin/initdb directory, and because I didn't have permisssions, I moved initdb.c,v to

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Sure. I logged into the main server machine and cd'ed to CVSROOT. I then when to the src/bin/initdb directory, and because I didn't have permisssions, I moved initdb.c,v to another file name then copied it to the original name so I owned the file. I

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Sure. I logged into the main server machine and cd'ed to CVSROOT. I then when to the src/bin/initdb directory, and because I didn't have permisssions, I moved initdb.c,v to another file name then copied it to the original name so I

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Alvaro Herrera
On Sun, Nov 23, 2003 at 06:59:45PM -0500, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Sure. I logged into the main server machine and cd'ed to CVSROOT. I then when to the src/bin/initdb directory, and because I didn't have permisssions, I moved initdb.c,v to another file name

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Bruce Momjian
Alvaro Herrera wrote: On Sun, Nov 23, 2003 at 06:59:45PM -0500, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Sure. I logged into the main server machine and cd'ed to CVSROOT. I then when to the src/bin/initdb directory, and because I didn't have permisssions, I moved

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: Um. Can anyone else check into those files now? Yes, I think so. The file used to be owned by Peter, but now by me: Oh, okay. I had the idea they should all be owned by the cvs daemon, but I guess that's not required.

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Alvaro Herrera wrote: BTW, I can see a whole lot of files with the executable bit: find pgsql-server/ -type f -perm +0333 -ls That command doesn't seem to work for me. He's looking for *either* write or execute permissions. AFAIK there is no reason

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Philip Yarra
On Mon, 24 Nov 2003 11:41 am, Bruce Momjian wrote: find pgsql-server/ -type f -perm +0333 -ls That command doesn't seem to work for me. I see: I think that should be -perm +0111: from man find: -perm +mode Any of the permission bits mode are set for the file. This would find

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Christopher Kings-Lynne
The other things that are executable look like they legitimately are scripts. If we consider that group-writability is bad (which ISTM we ought to) then there are a *ton* of files with the wrong permissions. I'd recommend getting Marc to fix it instead of hacking about with a one-file-at-a-time

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Bruce Momjian
Christopher Kings-Lynne wrote: The other things that are executable look like they legitimately are scripts. If we consider that group-writability is bad (which ISTM we ought to) then there are a *ton* of files with the wrong permissions. I'd recommend getting Marc to fix it instead

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Christopher Kings-Lynne wrote: You could consider adding a script to CVSROOT module to fix permissions upon commit? Some files need execute bits, like perl scripts. Sure, but couldn't we automatically turn off the write bits?

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Marc G. Fournier
On Sun, 23 Nov 2003, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Christopher Kings-Lynne wrote: You could consider adding a script to CVSROOT module to fix permissions upon commit? Some files need execute bits, like perl scripts. Sure, but couldn't we automatically turn

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Tom Lane
Marc G. Fournier [EMAIL PROTECTED] writes: On Sun, 23 Nov 2003, Tom Lane wrote: Sure, but couldn't we automatically turn off the write bits? Just curious, but what do the write bits harm? They're just extra protection against making a dumb mistake; the old belt-AND-suspenders theory. If we

Re: [HACKERS] Executable files in CVS

2003-11-23 Thread Peter Eisentraut
Tom Lane writes: Besides, it's a tad odd to see files that are marked group writable but not owner writable. You've got to agree there's not much sense in that. How else are you going to commit files? /usr/bin/cvs is not setuid, so the only way you can write to these files is being in the