[HACKERS] Explain analyze getrusage tracking

2010-11-14 Thread Greg Stark
This is an update to my earlier patch to add getrusage resource tracking to EXPLAIN ANALYZE. With this patch you get something like: QUERY PLAN ---

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-15 Thread Robert Haas
On Sun, Nov 14, 2010 at 9:33 PM, Greg Stark wrote: > This is an update to my earlier patch to add getrusage resource > tracking to EXPLAIN ANALYZE. > > With this patch you get something like: > >                                                  QUERY PLAN >

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-16 Thread Greg Stark
On Tue, Nov 16, 2010 at 2:43 AM, Robert Haas wrote: > I don't really think these changes to the INSTR macros make much > sense.  The macros don't really add much notational convenience; > they're mostly wrappers to make the WIN32 and non-WIN32 cases work > similarly for the instrumentation stuff,

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-16 Thread Robert Haas
On Tue, Nov 16, 2010 at 12:19 PM, Greg Stark wrote: > On Tue, Nov 16, 2010 at 2:43 AM, Robert Haas wrote: >> I don't really think these changes to the INSTR macros make much >> sense. The macros don't really add much notational convenience; >> they're mostly wrappers to make the WIN32 and non-WI

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-16 Thread Greg Stark
On Tue, Nov 16, 2010 at 11:38 AM, Robert Haas wrote: >> I think we should have a project policy of always printing memory and >> disk usage in kB, MB, GB etc unless they're functions returning an >> integer intended for machine use. > > rhaas=# set work_mem to '1048577kB'; Interesting. Though in

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-16 Thread Robert Haas
On Tue, Nov 16, 2010 at 2:53 PM, Greg Stark wrote: >> Yeah, VERBOSE is kind of a catch-all for things that we don't have >> individual flags for.  But I think it's better for each piece of data >> to depend on one setting, rather than a combination of two or more >> settings.  Otherwise you end up

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-22 Thread Magnus Hagander
On Mon, Nov 15, 2010 at 03:33, Greg Stark wrote: > This is an update to my earlier patch to add getrusage resource > tracking to EXPLAIN ANALYZE. > > With this patch you get something like: > >                                                  QUERY PLAN > --

Re: [HACKERS] Explain analyze getrusage tracking

2010-11-22 Thread Greg Stark
On Mon, Nov 22, 2010 at 12:40 PM, Magnus Hagander wrote: > I tried building this under windows, and got a bunch of errors. Thanks! -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hacke