Re: [HACKERS] FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch

2014-08-27 Thread Alvaro Herrera
Craig Ringer wrote: > FOR SHARE|UPDATE NOWAIT will still block if they have to follow a ctid > chain because the call to EvalPlanQualFetch doesn't take a param for > noWait, so it doesn't know not to block if the updated row can't be locked. Applied with some further editorialization. In another

Re: [HACKERS] FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch

2014-05-31 Thread Andres Freund
Hi, On 2014-01-31 16:28:08 -0500, Bruce Momjian wrote: > On Fri, Aug 2, 2013 at 04:00:03PM +0800, Craig Ringer wrote: > > FOR SHARE|UPDATE NOWAIT will still block if they have to follow a ctid > > chain because the call to EvalPlanQualFetch doesn't take a param for > > noWait, so it doesn't know

Re: [HACKERS] FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch

2014-02-02 Thread Craig Ringer
On 02/01/2014 05:28 AM, Bruce Momjian wrote: > On Fri, Aug 2, 2013 at 04:00:03PM +0800, Craig Ringer wrote: >> FOR SHARE|UPDATE NOWAIT will still block if they have to follow a ctid >> chain because the call to EvalPlanQualFetch doesn't take a param for >> noWait, so it doesn't know not to block i

Re: [HACKERS] FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch

2014-01-31 Thread Bruce Momjian
On Fri, Aug 2, 2013 at 04:00:03PM +0800, Craig Ringer wrote: > FOR SHARE|UPDATE NOWAIT will still block if they have to follow a ctid > chain because the call to EvalPlanQualFetch doesn't take a param for > noWait, so it doesn't know not to block if the updated row can't be locked. > > The attach

[HACKERS] FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch

2013-08-02 Thread Craig Ringer
FOR SHARE|UPDATE NOWAIT will still block if they have to follow a ctid chain because the call to EvalPlanQualFetch doesn't take a param for noWait, so it doesn't know not to block if the updated row can't be locked. The attached patch against master includes an isolationtester spec to demonstrate