RE: [HACKERS] FW: Postgresql on win32

2001-01-24 Thread Peter Eisentraut
Magnus Hagander writes: Peter Eisentraut [EMAIL PROTECTED] writes: We're losing this battle anyway. Look into src/interfaces/libpq/libpq.rc. Ugh. Magnus, is there any reasonable way to generate that thing on the fly on Win32? It's the same thing as with version.h - e.g. not

Re: [HACKERS] FW: Postgresql on win32

2001-01-24 Thread Bruce Momjian
I have added ./include/config.h.win32 to the RELEASE_CHANGES update list. Magnus Hagander writes: Peter Eisentraut [EMAIL PROTECTED] writes: We're losing this battle anyway. Look into src/interfaces/libpq/libpq.rc. Ugh. Magnus, is there any reasonable way to generate that

[HACKERS] FW: Postgresql on win32

2001-01-22 Thread Magnus Hagander
Seems this one got lost along the way somewhere. At least, I didn't get it back... Trying a resend. //Magnus -Original Message- From: Magnus Hagander Sent: den 20 januari 2001 14:29 To: '[EMAIL PROTECTED]' Subject: Postgresql on win32 Hello! Here is a patch

AW: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Zeugswetter Andreas SB
The problem is that there are strings being allocated from libpq.dll using PQExpBuffers (for example, initPQExpBuffer() on line 92 of input.c). These are being allocated using the malloc function used by libpq.dll. This function *may* be different from the malloc function used by

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: 2) PG_VERSION is no longer defined in version.h[.in], but in configure.in. Since we don't do configure on native win32, we need to put it in config.h.win32 :-( Putting ! #define PG_VERSION 7.1 ! #define PG_VERSION_STR "7.1 (win32)" into

Re: AW: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Tom Lane
Zeugswetter Andreas SB [EMAIL PROTECTED] writes: It is possible to make the above work (at least on MSVC). The switch is /MD that needs to be used for both the psql.exe and libpq.dll. This forces the use of Multithreaded DLL runtime libraries. I like this answer. We should be trying to

RE: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Magnus Hagander
Magnus Hagander [EMAIL PROTECTED] writes: 2) PG_VERSION is no longer defined in version.h[.in], but in configure.in. Since we don't do configure on native win32, we need to put it in config.h.win32 :-( Putting ! #define PG_VERSION 7.1 ! #define PG_VERSION_STR "7.1 (win32)"

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Question: Can I assume that configure.in stays the way it is now? In the way that if I could just extract the line "VERSION='xyz'" from it, that will continue to work? It might be possible to do something around that. That'd be OK with me. I don't

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Pete Forman
Tom Lane writes: That'd be OK with me. I don't suppose Win32 has "sed" though :-( Cygwin does. We can worry about native support for PostgreSQL later ;-) -- Pete Forman -./\.- Disclaimer: This post is originated WesternGeco -./\.- by myself and does not

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Tom Lane
Pete Forman [EMAIL PROTECTED] writes: Tom Lane writes: That'd be OK with me. I don't suppose Win32 has "sed" though :-( Cygwin does. We can worry about native support for PostgreSQL later ;-) This is the native support we are talking about. The Cygwin port uses configure, no?

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Peter Eisentraut
Tom Lane writes: Actually, it might be easier to go back to keeping it in a file version.h (NOT .in) which configure could read it out of. I never figured out why Peter put it directly in configure.in in the first place; that means it is actually hard-coded in two files (configure.in and

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane writes: Actually, it might be easier to go back to keeping it in a file version.h (NOT .in) which configure could read it out of. I never figured out why Peter put it directly in configure.in in the first place; that means it is actually

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Peter Eisentraut
Tom Lane writes: Putting ! #define PG_VERSION 7.1 ! #define PG_VERSION_STR "7.1 (win32)" into config.h.win32 is most certainly *not* an acceptable solution. We are not going to start maintaining this file's idea of the version by hand, now that we've centralized the version info

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: We're losing this battle anyway. Look into src/interfaces/libpq/libpq.rc. Ugh. Magnus, is there any reasonable way to generate that thing on the fly on Win32? One could imagine fixing this in configure --- have configure generate libpq.rc from

Re: [HACKERS] FW: Postgresql on win32

2001-01-22 Thread Bruce Momjian
Tom Lane writes: Putting ! #define PG_VERSION 7.1 ! #define PG_VERSION_STR "7.1 (win32)" into config.h.win32 is most certainly *not* an acceptable solution. We are not going to start maintaining this file's idea of the version by hand, now that we've centralized the version