Re: [HACKERS] First patch -- somewhat trivial feature

2013-11-13 Thread Robert Berry
Snowman -- Thanks for feedback. I imagined this feature could be useful in a couple of contexts, though mainly in the sense of documenting query optimization efforts. In one case you may be tweaking cost parameters and having a built in record of the parameters in the explain output can make tha

Re: [HACKERS] First patch -- somewhat trivial feature

2013-11-13 Thread David Johnston
Stephen Frost wrote > * Robert Berry ( > berrydigital@ > ) wrote: >> This is my first attempt at writing a patch, so it's pretty simple. > > Neat! > >> seq_page: 1.00, rnd_page: 4.00, cpu_tup: 0.01, >> cpu_ind: 0.005000, cpu_op: 0.002500 >> amenabled: 1

Re: [HACKERS] First patch -- somewhat trivial feature

2013-11-13 Thread Stephen Frost
* Robert Berry (berrydigi...@gmail.com) wrote: > This is my first attempt at writing a patch, so it's pretty simple. Neat! > seq_page: 1.00, rnd_page: 4.00, cpu_tup: 0.01, > cpu_ind: 0.005000, cpu_op: 0.002500 > amenabled: 111 > > The bit vector

[HACKERS] First patch -- somewhat trivial feature

2013-11-13 Thread Robert Berry
This is my first attempt at writing a patch, so it's pretty simple. Commit log sums it up: Adds a convenience feature to the explain command which prints out GUC cost parameters in explain text output. For example: explain (params) select * from table; will include text output like