Re: [HACKERS] Fix GetOldestXmin comment

2017-05-30 Thread Masahiko Sawada
On Tue, May 30, 2017 at 11:07 PM, Amit Kapila wrote: > On Tue, May 30, 2017 at 6:32 AM, Masahiko Sawada > wrote: >> Hi, >> >> While reading source code, I realized that comment of GetOldestXmin mentions; >> >> * if rel = NULL and there are no transactions running in the current >> * database

Re: [HACKERS] Fix GetOldestXmin comment

2017-05-30 Thread Amit Kapila
On Tue, May 30, 2017 at 6:32 AM, Masahiko Sawada wrote: > Hi, > > While reading source code, I realized that comment of GetOldestXmin mentions; > > * if rel = NULL and there are no transactions running in the current > * database, GetOldestXmin() returns latestCompletedXid. > > However, in tha

[HACKERS] Fix GetOldestXmin comment

2017-05-29 Thread Masahiko Sawada
Hi, While reading source code, I realized that comment of GetOldestXmin mentions; * if rel = NULL and there are no transactions running in the current * database, GetOldestXmin() returns latestCompletedXid. However, in that case if I understand correctly GetOldestXmin() actually returns late