Re: [HACKERS] Fix compiler warnings in Cube Extension

On 29 December 2015 at 07:38, Tom Lane wrote: > David Rowley writes: > > My compiler is complaining about cube_coord() and cube_coord_llur() not > > returning a value on all code paths. > > Yeah, looking at that code, this would be expected from

[HACKERS] Fix compiler warnings in Cube Extension

Hi, My compiler is complaining about cube_coord() and cube_coord_llur() not returning a value on all code paths. On looking at this I noticed that this is happening due the pattern used is not quite aligned with other code, as normally we do: if () ereport(); do stuff;

Re: [HACKERS] Fix compiler warnings in Cube Extension

David Rowley writes: > My compiler is complaining about cube_coord() and cube_coord_llur() not > returning a value on all code paths. Yeah, looking at that code, this would be expected from any compiler that doesn't know that ereport() doesn't return. On it now.