[HACKERS] Fix for compiler warning in reloptions.c

2009-01-05 Thread Bruce Momjian
The attached applied patch prevents a compiler warning; the compiler doesn't know about our elog(ERROR) exit case. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be

Re: [HACKERS] Fix for compiler warning in reloptions.c

2009-01-05 Thread Alvaro Herrera
Bruce Momjian wrote: The attached applied patch prevents a compiler warning; the compiler doesn't know about our elog(ERROR) exit case. Hmm, I don't like your fix; ISTM it would be better to set the variable only in the default: case (or maybe change the break for a return). -- Alvaro

Re: [HACKERS] Fix for compiler warning in reloptions.c

2009-01-05 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: The attached applied patch prevents a compiler warning; the compiler doesn't know about our elog(ERROR) exit case. Hmm, I don't like your fix; ISTM it would be better to set the variable only in the default: case (or maybe change the break for a