Re: [HACKERS] Fix for compiler warning in reloptions.c

Alvaro Herrera wrote: > Bruce Momjian wrote: > > The attached applied patch prevents a compiler warning; the compiler > > doesn't know about our elog(ERROR) exit case. > > Hmm, I don't like your fix; ISTM it would be better to set the variable > only in the default: case (or maybe change the "bre

Re: [HACKERS] Fix for compiler warning in reloptions.c

Bruce Momjian wrote: > The attached applied patch prevents a compiler warning; the compiler > doesn't know about our elog(ERROR) exit case. Hmm, I don't like your fix; ISTM it would be better to set the variable only in the default: case (or maybe change the "break" for a "return"). -- Alvaro H

[HACKERS] Fix for compiler warning in reloptions.c

The attached applied patch prevents a compiler warning; the compiler doesn't know about our elog(ERROR) exit case. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Inde