Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-07 Thread Bruce Momjian
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: I certainly hope that pg_regress isn't freeing the strings it passes to putenv() ... pg_regress does not restore these settings (it says with C/English) so the code is different.

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-04 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: I certainly hope that pg_regress isn't freeing the strings it passes to putenv() ... pg_regress does not restore these settings (it says with C/English) so the code is different. That's not what I'm on about.

[HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Greg Sabino Mullane wrote: Specifically, LANGUAGE changes the headers of pg_controldata (but not the actual output, LC_ALL does that). Thanks for the nudge, I'll get to rewriting some code. pg_upgrade does this in controldata.c

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of mié sep 01 16:35:18 -0400 2010: I have implemented your suggestion of setting LANG, LANGUAGE, and LC_MESSAGES based on code in pg_regress.c; that is the only place I see where we force English, and it certainly has received more testing. I think a

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Bruce Momjian's message of mié sep 01 16:35:18 -0400 2010: I have implemented your suggestion of setting LANG, LANGUAGE, and LC_MESSAGES based on code in pg_regress.c; that is the only place I see where we force English, and it

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Bruce Momjian
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Bruce Momjian's message of mi?? sep 01 16:35:18 -0400 2010: I have implemented your suggestion of setting LANG, LANGUAGE, and LC_MESSAGES based on code in pg_regress.c; that is the only place I see where we

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: However, that's something for 9.1 and beyond. Bruce's immediate problem is what to do in pg_upgrade in 9.0, and there I concur that he should duplicate what pg_regress is doing. OK, here is a patch that sets all the variables that

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: However, that's something for 9.1 and beyond. Bruce's immediate problem is what to do in pg_upgrade in 9.0, and there I concur that he should duplicate what pg_regress is doing. OK, here is a patch that sets all

Re: [HACKERS] Fix for pg_upgrade's forcing pg_controldata into English

2010-09-01 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: I certainly hope that pg_regress isn't freeing the strings it passes to putenv() ... pg_regress does not restore these settings (it says with C/English) so the code is different. That's not what I'm on about. You're trashing strings