Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-04-01 Thread Alvaro Herrera
Michael Paquier wrote: > Here is v3 then, switching to "invalid socket" for those error > messages. There are two extra messages in fe-misc.c and > libpqwalreceiver.c that need a rewording that I have detected as well. Peter Eisentraut pushed this as a40814d7a. -- Álvaro Herrera

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-03-07 Thread Michael Paquier
On Sun, Mar 6, 2016 at 12:52 PM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> On 2/17/16 10:52 PM, Michael Paquier wrote: >> > On Thu, Feb 18, 2016 at 1:58 AM, Alvaro Herrera >> > wrote: >> >> Michael Paquier wrote: >> >>> Hi all, >> >>>

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-03-05 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 2/17/16 10:52 PM, Michael Paquier wrote: > > On Thu, Feb 18, 2016 at 1:58 AM, Alvaro Herrera > > wrote: > >> Michael Paquier wrote: > >>> Hi all, > >>> > >>> After looking at Alvaro's message mentioning the handling of > >>> PQsocket() for

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-03-05 Thread Peter Eisentraut
On 2/17/16 10:52 PM, Michael Paquier wrote: > On Thu, Feb 18, 2016 at 1:58 AM, Alvaro Herrera > wrote: >> Michael Paquier wrote: >>> Hi all, >>> >>> After looking at Alvaro's message mentioning the handling of >>> PQsocket() for invalid sockets, I just had a look by

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-02-17 Thread Michael Paquier
On Thu, Feb 18, 2016 at 1:58 AM, Alvaro Herrera wrote: > Michael Paquier wrote: >> Hi all, >> >> After looking at Alvaro's message mentioning the handling of >> PQsocket() for invalid sockets, I just had a look by curiosity at >> other calls of this routine, and found a

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-02-17 Thread Alvaro Herrera
Michael Paquier wrote: > Hi all, > > After looking at Alvaro's message mentioning the handling of > PQsocket() for invalid sockets, I just had a look by curiosity at > other calls of this routine, and found a couple of issues: > 1) In vacuumdb.c, init_slot() does not check for the return value of

[HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-02-16 Thread Michael Paquier
Hi all, After looking at Alvaro's message mentioning the handling of PQsocket() for invalid sockets, I just had a look by curiosity at other calls of this routine, and found a couple of issues: 1) In vacuumdb.c, init_slot() does not check for the return value of PQsocket(): slot->sock =