Re: [HACKERS] Fix memset usage in pgcrypto

2014-04-17 Thread Bruce Momjian
On Mon, Mar 31, 2014 at 09:03:41PM -0400, Bruce Momjian wrote: > On Thu, Dec 26, 2013 at 03:42:12PM +0200, Marko Kreen wrote: > > http://www.viva64.com/en/b/0227/ reported that on-stack memset()s > > might be optimized away by compilers. Fix it. > > > > * Replace memset() with px_memset() > > * A

Re: [HACKERS] Fix memset usage in pgcrypto

2014-03-31 Thread Bruce Momjian
On Thu, Dec 26, 2013 at 03:42:12PM +0200, Marko Kreen wrote: > http://www.viva64.com/en/b/0227/ reported that on-stack memset()s > might be optimized away by compilers. Fix it. > > * Replace memset() with px_memset() > * Add px_memset to copy_crlf() > * ADd px_memset to pgp-s2k.c Where are we on

Re: [HACKERS] Fix memset usage in pgcrypto

2014-01-21 Thread Marko Kreen
On Mon, Jan 20, 2014 at 06:49:21PM -0300, Alvaro Herrera wrote: > Marko Kreen escribió: > > http://www.viva64.com/en/b/0227/ reported that on-stack memset()s > > might be optimized away by compilers. Fix it. > > Just to clarify, this needs to be applied to all branches, right? If > so, does the

Re: [HACKERS] Fix memset usage in pgcrypto

2014-01-20 Thread Alvaro Herrera
Marko Kreen escribió: > http://www.viva64.com/en/b/0227/ reported that on-stack memset()s > might be optimized away by compilers. Fix it. Just to clarify, this needs to be applied to all branches, right? If so, does the version submitted apply cleanly to all of them? -- Álvaro Herrera

[HACKERS] Fix memset usage in pgcrypto

2013-12-26 Thread Marko Kreen
http://www.viva64.com/en/b/0227/ reported that on-stack memset()s might be optimized away by compilers. Fix it. * Replace memset() with px_memset() * Add px_memset to copy_crlf() * ADd px_memset to pgp-s2k.c -- marko diff --git a/contrib/pgcrypto/crypt-blowfish.c b/contrib/pgcrypto/crypt-blowf