Re: [HACKERS] Fix warnings and typo in dshash

2017-09-03 Thread Amit Kapila
On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro wrote: > On Sun, Sep 3, 2017 at 6:57 PM, Amit Kapila wrote: >> I am seeing below warnings (on Win7) in dshash.c >> >> 1> dshash.c >> 1>src/backend/lib/dshash.c(318): warning C4334: '<<' : result

Re: [HACKERS] Fix warnings and typo in dshash

2017-09-03 Thread Tom Lane
Thomas Munro writes: > Aside from these 3 warnings, it looks like the other 17 are all > "warning C4005: 'HAVE_LONG_LONG_INT_64': macro redefinition". Oh, I think that one might be my fault. I tweaked pg_config.h.win32 in 9d6b160d7 to use "#define

Re: [HACKERS] Fix warnings and typo in dshash

2017-09-03 Thread Tom Lane
Amit Kapila writes: > I am seeing below warnings (on Win7) in dshash.c > 1> dshash.c > 1>src/backend/lib/dshash.c(318): warning C4334: '<<' : result of > 32-bit shift implicitly converted to 64 bits (was 64-bit shift > intended?) > 1>src/backend/lib/dshash.c(679):

Re: [HACKERS] Fix warnings and typo in dshash

2017-09-03 Thread Thomas Munro
On Sun, Sep 3, 2017 at 6:57 PM, Amit Kapila wrote: > I am seeing below warnings (on Win7) in dshash.c > > 1> dshash.c > 1>src/backend/lib/dshash.c(318): warning C4334: '<<' : result of > 32-bit shift implicitly converted to 64 bits (was 64-bit shift > intended?) >

[HACKERS] Fix warnings and typo in dshash

2017-09-03 Thread Amit Kapila
I am seeing below warnings (on Win7) in dshash.c 1> dshash.c 1>src/backend/lib/dshash.c(318): warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) 1>src/backend/lib/dshash.c(679): warning C4334: '<<' : result of 32-bit shift implicitly