Simon Riggs <[EMAIL PROTECTED]> writes:
>> So thinking we should test XLogArchiveCheckDone() for both
>> stopxlogfilename and history file and then stat for the stop WAL file:
> This seems better.
Somehow I missed the 5-Apr patch that introduced this bogosity.
Next time you make a fundamental cha
Simon Riggs <[EMAIL PROTECTED]> writes:
> You sound like you're in the middle of doing this yourself. Or would you
> like me to do that?
Yeah, done and committed.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to y
On Mon, 2008-09-08 at 11:57 -0400, Tom Lane wrote:
> Simon Riggs <[EMAIL PROTECTED]> writes:
> >> So thinking we should test XLogArchiveCheckDone() for both
> >> stopxlogfilename and history file and then stat for the stop WAL file:
>
> > This seems better.
>
> Somehow I missed the 5-Apr patch t
On Fri, Sep 5, 2008 at 7:32 PM, Simon Riggs <[EMAIL PROTECTED]> wrote:
>
> Would you mind if I asked you to be the official reviewer of this patch
> for the latest CommitFest? It would help greatly, since you understand
> the issue and clearly the code also. Thanks, if possible.
OK. I'll try to re
On Fri, 2008-08-08 at 11:47 +0900, Fujii Masao wrote:
> On Thu, Aug 7, 2008 at 11:34 PM, Simon Riggs <[EMAIL PROTECTED]> wrote:
> >
> > On Thu, 2008-08-07 at 14:59 +0100, Simon Riggs wrote:
> >
> >> I'll do a patch. Thanks for your input.
> >
> > Please review attached patch.
>
> Thank you for yo
On Fri, 2008-08-08 at 12:57 +0100, Simon Riggs wrote:
> > Yes, statement_timeout may help. But, I don't want to use it, because the
> > *successful* backup is canceled.
> >
> > How about checking whether the stoppoint was archived by comparing with
> > the last WAL archived. The archiver process
On Fri, 2008-08-08 at 11:47 +0900, Fujii Masao wrote:
> On Thu, Aug 7, 2008 at 11:34 PM, Simon Riggs <[EMAIL PROTECTED]> wrote:
> >
> In this situation, the history file (00010004.0020.backup)
> is behind the stoppoint (00010004) in the alphabetic order.
> So,
On Thu, Aug 7, 2008 at 11:34 PM, Simon Riggs <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-08-07 at 14:59 +0100, Simon Riggs wrote:
>
>> I'll do a patch. Thanks for your input.
>
> Please review attached patch.
Thank you for your patch!
But, there are two problems in this patch, I think.
> !
On Thu, 2008-08-07 at 14:59 +0100, Simon Riggs wrote:
> I'll do a patch. Thanks for your input.
Please review attached patch.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Index: src/backend/access/transam/xlog.c
==
On Thu, 2008-08-07 at 21:11 +0900, Fujii Masao wrote:
> In HEAD, pg_stop_backup waits until the history file has been archived.
> But, in order to ensure that the last wal file was archived, pg_stop_backup
> should wait until not only the history file but also the backup stopping wal
> file has b
Hi
In HEAD, pg_stop_backup waits until the history file has been archived.
But, in order to ensure that the last wal file was archived, pg_stop_backup
should wait until not only the history file but also the backup stopping wal
file has been archived, I think.
Because the alphabetic order of the
11 matches
Mail list logo