Re: [HACKERS] GCC 4.4 compiler warnings

2009-05-01 Thread Andy Lester
On Apr 29, 2009, at 11:32 AM, Tom Lane wrote: As of CVS HEAD and gcc 4.4.0-3, we seem to be warning-free in a standard build. I did not try many optional build flags though. I'm also working on a set of extra-stringent build flags for GCC 4.4. The more we can get the compiler to watch f

Re: [HACKERS] GCC 4.4 compiler warnings

2009-05-01 Thread Tom Lane
I wrote: > Since there isn't any obvious better way to do this, I consider this > warning to be a gcc bug, and have filed it accordingly: > https://bugzilla.redhat.com/show_bug.cgi?id=497545 As of CVS HEAD and gcc 4.4.0-3, we seem to be warning-free in a standard build. I did not try many optiona

Re: [HACKERS] GCC 4.4 compiler warnings

2009-04-26 Thread Grzegorz Jaskiewicz
On 26 Apr 2009, at 16:22, Tom Lane wrote: Grzegorz Jaskiewicz writes: tab-complete.c:666: warning: implicit declaration of function 'completion_matches' Are you sure you have a real installation of readline? OSX is notorious for providing a bogus one, particularly in older release series.

Re: [HACKERS] GCC 4.4 compiler warnings

2009-04-26 Thread Tom Lane
Grzegorz Jaskiewicz writes: > tab-complete.c:666: warning: implicit declaration of function > 'completion_matches' Are you sure you have a real installation of readline? OSX is notorious for providing a bogus one, particularly in older release series. regards, tom lane

Re: [HACKERS] GCC 4.4 compiler warnings

2009-04-26 Thread Grzegorz Jaskiewicz
and a quick one on mac os x, which looks like it has something to do with COMPLETE_WITH_LIST() and macros like that, and maybe with completion_matches on mac os x. I don't get these on linux. This is from gcc4.4 with -O3 (which obviously causes gcc to find more potential warnings). tab-com

Re: [HACKERS] GCC 4.4 compiler warnings

2009-04-24 Thread Grzegorz Jaskiewicz
reloptions.c: In function ‘extractRelOptions’: reloptions.c:731: warning: value computed is not used heapam.c: In function ‘heapgettup’: heapam.c:458: warning: value computed is not used heapam.c:458: warning: value computed is not used heapam.c: In function ‘heapgettup_pagemode’: heapa

Re: [HACKERS] GCC 4.4 compiler warnings

2009-04-24 Thread Tom Lane
Peter Eisentraut writes: > GCC 4.4 produces a bunch of new compiler warnings against 8.4; see attached > output. Some of these are related to our old friend fastgetattr(), but it's > a > bit too late for me to make sense of it now. > As we have grown accustomed to warnings-free builds, it wou

Re: [HACKERS] GCC 4.4 compiler warnings

2009-04-22 Thread Grzegorz Jaskiewicz
if that's without -O3, than please retry it with. It will give even more. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] GCC 4.4 compiler warnings

2009-04-22 Thread Peter Eisentraut
GCC 4.4 produces a bunch of new compiler warnings against 8.4; see attached output. Some of these are related to our old friend fastgetattr(), but it's a bit too late for me to make sense of it now. As we have grown accustomed to warnings-free builds, it would be nice to fix these. reloptions.