Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 22:18, Jeff Janes wrote: In Danish, apparently 'AA' 'WA', so two more rows show up. Yes of course We have three extra vowels following Z (namely Æ, Ø and Å) and for keyboard missing those essential keys we have an official

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Kevin Grittner
Svenne Krap svenne.li...@krap.dk wrote: On 18-06-2013 22:18, Jeff Janes wrote:    In Danish, apparently 'AA' 'WA', so two more rows show up. Yes of course We have three extra vowels following Z (namely Æ, Ø and Å) and for keyboard missing those essential keys we have an official

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Andres Freund
On 2013-06-19 06:18:20 -0700, Kevin Grittner wrote: Svenne Krap svenne.li...@krap.dk wrote: On 18-06-2013 22:18, Jeff Janes wrote:    In Danish, apparently 'AA' 'WA', so two more rows show up. Yes of course We have three extra vowels following Z (namely Æ, Ø and Å) and for

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Andres Freund
On 2013-06-19 15:23:16 +0200, Andres Freund wrote: On 2013-06-19 06:18:20 -0700, Kevin Grittner wrote: Svenne Krap svenne.li...@krap.dk wrote: On 18-06-2013 22:18, Jeff Janes wrote:    In Danish, apparently 'AA' 'WA', so two more rows show up. Yes of course We have

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Peter Eisentraut
On 6/19/13 9:18 AM, Kevin Grittner wrote: Svenne Krap svenne.li...@krap.dk wrote: On 18-06-2013 22:18, Jeff Janes wrote: In Danish, apparently 'AA' 'WA', so two more rows show up. Yes of course We have three extra vowels following Z (namely Æ, Ø and Å) and for keyboard missing

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Kevin Grittner
Peter Eisentraut pete...@gmx.net wrote: On 6/19/13 9:18 AM, Kevin Grittner wrote: Does anyone object to the attached change, so that regression tests pass when run in a Danish locale?  I think it should be back-patched to 9.2, where the test was introduced. Yes, that should be fixed.  I

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19-06-2013 17:41, Kevin Grittner wrote: OK, pushed without the comment. Works like a charm :) Svenne -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Jeff Janes
On Wed, Jun 19, 2013 at 8:41 AM, Kevin Grittner kgri...@ymail.com wrote: Peter Eisentraut pete...@gmx.net wrote: On 6/19/13 9:18 AM, Kevin Grittner wrote: Does anyone object to the attached change, so that regression tests pass when run in a Danish locale? I think it should be

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Kevin Grittner
Jeff Janes jeff.ja...@gmail.com wrote: Kevin Grittner kgri...@ymail.com wrote: Peter Eisentraut pete...@gmx.net wrote: On 6/19/13 9:18 AM, Kevin Grittner wrote: Does anyone object to the attached change, so that regression tests pass when run in a Danish locale?  I think it should be

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Peter Eisentraut
On Wed, 2013-06-19 at 14:50 -0700, Jeff Janes wrote: Is there an infrastructure to use a different expected file depending on the LANG used? Not really. A couple of years ago I did the same exercise you just did, and we just fixed most of what was reasonable to fix by adjusting the test

[HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
Hi All. I just subscribed to RRReviewers (that should be pronounce with a nice rolling r-r-reviewers, right?) As part of my getting up to speed, I tried to build and run test on the current master 073d7cb513f5de44530f4bdbaaa4b5d4cce5f984 Basically I did: 1) Clone into new dir 2) ./configure

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Kevin Grittner
Svenne Krap svenne.li...@krap.dk wrote: current master 073d7cb513f5de44530f4bdbaaa4b5d4cce5f984 I was surprised to see that an index-test failed. It works for me.  Could you paste or attach some detail? -- Kevin Grittner EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 18:40, Svenne Krap wrote: Any ideas what might have happened? After doing some more digging... My laptop (which runs PostgreSQL 9.2.4 on x86_64-pc-linux-gnu, compiled by x86_64-pc-linux-gnu-gcc (Gentoo 4.7.3 p1.0, pie-0.5.5)

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 20:17, Kevin Grittner wrote: I was surprised to see that an index-test failed. It works for me. Could you paste or attach some detail? Gladly, if you tell me what would be relevant to attach :) I am brand new to the postgresql

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Kevin Grittner
Svenne Krap svenne.li...@krap.dk wrote: On 18-06-2013 20:17, Kevin Grittner wrote: I was surprised to see that an index-test failed. It works for me.  Could you paste or attach some detail? Gladly, if you tell me what would be relevant to attach :) I am brand new to the postgresql source

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 20:48, Kevin Grittner wrote: Apologies; I somehow missed the file attached to your initial post. That's the sort of thing I was looking for. Aplogy accepted... :) Having reviewed that, the source code comments indicate it is for

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 21:04, Svenne Krap wrote: (sk@[local]:5432) [sk] \l List of databases Name | Owner | Encoding | Collate | Ctype| Access privileges - Arghh... crappy mailer... I have

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Jeff Janes
On Tue, Jun 18, 2013 at 11:20 AM, Svenne Krap svenne.li...@krap.dk wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 18:40, Svenne Krap wrote: Any ideas what might have happened? After doing some more digging... My laptop (which runs PostgreSQL 9.2.4 on

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Alvaro Herrera
Jeff Janes escribió: On Tue, Jun 18, 2013 at 11:20 AM, Svenne Krap svenne.li...@krap.dk wrote: As I have no real idea of what ~~ is for an operator (I have looked it up as scalarltjoinsel), but I cannot find any semantics for it in the docs*... So I have no way of manually checking the

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Kevin Grittner
Svenne Krap svenne.li...@krap.dk wrote: I have the information attached here instead... I find it suspicious that the test is using an index which sorts first by the f1 column, then later by f1 text_pattern_ops column.  I'm not 100% sure whether the test is bad or you have found a bug, although

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 21:14, Jeff Janes wrote: But 9.2.4 does pass make check, and only fails if you reproduce those things manually? No, I was lazy and used the (distribution-installed) 9.2 I have tried make check on REL_9_2_4 and that fails to

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 21:41, Svenne Krap wrote: I will dig futher and get back... The regression test was added in 9.2, the earliest interesting commit is d6d5f67b5b98b1685f9158e9d00a726afb2ae789, where Tom Lane changes the definition to the current.

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Kevin Grittner
Svenne Krap svenne.li...@krap.dk wrote: I am happy to run whatever relevant tests you can dream up, but I am fresh out of ideas :) psql regression begin; drop index dupindexcols_i; SELECT count(*) FROM dupindexcols   WHERE f1 'WA' and id 1000 and f1 ~~ 'YX'; rollback; select f1 from

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Jeff Janes
On Tue, Jun 18, 2013 at 12:51 PM, Svenne Krap svenne.li...@krap.dk wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18-06-2013 21:41, Svenne Krap wrote: I will dig futher and get back... The regression test was added in 9.2, the earliest interesting commit is

Re: [HACKERS] Git-master regression failure

2013-06-18 Thread Kevin Grittner
Jeff Janes jeff.ja...@gmail.com wrote: The problem is the f1 'WA' part of the query.  In Danish, apparently 'AA' 'WA', so two more rows show up. Thanks -- I didn't have the right locale installed, and wasn't quite sure what package to install to get it. So, the test is bad, rather than