Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-08 Thread Hiroshi Inoue
Tom Lane wrote: > > Hiroshi Inoue <[EMAIL PROTECTED]> writes: > > Is it OK to commit the change before 7.1 release ? > > I want to do it before forgetting this issue. > > If that fixes the problem for you, then commit it. I was waiting to > hear back whether you still saw a crash or not... > I

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-08 Thread Tom Lane
Hiroshi Inoue <[EMAIL PROTECTED]> writes: > Is it OK to commit the change before 7.1 release ? > I want to do it before forgetting this issue. If that fixes the problem for you, then commit it. I was waiting to hear back whether you still saw a crash or not... regards, t

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-08 Thread Hiroshi Inoue
I Inoue wrote: > > Tom Lane wrote: > > > > Hiroshi Inoue <[EMAIL PROTECTED]> writes: > > > [ backtrace snipped ] > > > > Hmm, this is definitely not operating as intended: LockWaitCancel is > > getting interrupted, because ProcessInterrupts may be called when it's > > trying to acquire the lockman

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-05 Thread Tom Lane
Hiroshi Inoue <[EMAIL PROTECTED]> writes: >> I suspect you will find that these crashes occur during the window just >> after > Sorry what does 'just after' mean ? > Isn't it during the semop() ? >> the semop() call in IpcSemaphoreLock() --- see the comment If an interrupt during the semop led

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-05 Thread Hiroshi Inoue
Tom Lane wrote: > > Hiroshi Inoue <[EMAIL PROTECTED]> writes: > > [ backtrace snipped ] > > Hmm, this is definitely not operating as intended: LockWaitCancel is > getting interrupted, because ProcessInterrupts may be called when it's > trying to acquire the lockmanager spinlock, and ProcessInterr

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-05 Thread Tom Lane
Hiroshi Inoue <[EMAIL PROTECTED]> writes: > [ backtrace snipped ] Hmm, this is definitely not operating as intended: LockWaitCancel is getting interrupted, because ProcessInterrupts may be called when it's trying to acquire the lockmanager spinlock, and ProcessInterrupts will see the ProcDiePendi

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-05 Thread Hiroshi Inoue
Tom Lane wrote: > > Hiroshi Inoue <[EMAIL PROTECTED]> writes: > > I sometimes encountered SEGV errors in my test case > > when I canceled the execution. > > Can you provide backtraces from these SEGVs? > ISTM the backtrace isn't sufficient to figure out how the error occured. As far as I see th

Re: [HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-04 Thread Tom Lane
Hiroshi Inoue <[EMAIL PROTECTED]> writes: > I sometimes encountered SEGV errors in my test case > when I canceled the execution. Can you provide backtraces from these SEGVs? > Probably it's due to the almost simultaneous arrival > of multiple signals and the following patch seems to > fix the bu

[HACKERS] How to handle waitingForLock in LockWaitCancel()

2001-03-04 Thread Hiroshi Inoue
Hi, I sometimes encountered SEGV errors in my test case when I canceled the execution. Probably it's due to the almost simultaneous arrival of multiple signals and the following patch seems to fix the bug. However I'm afraid that the change should cause another bug. Comments ? Regards, Hiroshi I