Re: [HACKERS] INSERT ... ON CONFLICT documentation clean-up patch

On 2015-11-10 14:28:16 -0800, Peter Geoghegan wrote: > Attached revision (rebase) of your modified version of my patch (the > modification you provided privately) has the following notable > changes: We might want do a bit further word-smithing, but it does indeed seem better to me this way. As

Re: [HACKERS] INSERT ... ON CONFLICT documentation clean-up patch

As discussed on IM, I think we should make the insert.sgml documentation even close to select.sgml than before, in that parameters ought to be discussed in different sections, and not in one large block. insert.sgml is too complicated for that approach now. Attached revision (rebase) of your

Re: [HACKERS] INSERT ... ON CONFLICT documentation clean-up patch

On 2015-10-11 17:54:24 -0700, Peter Geoghegan wrote: > + > + > + INSERT statements with ON > + CONFLICT clauses do not work sensibly with the partitioning > + schemes shown here, since trigger functions are not currently > + capable of examining the structure of the

Re: [HACKERS] INSERT ... ON CONFLICT documentation clean-up patch

Hi, On Wed, Oct 14, 2015 at 9:38 AM, Andres Freund wrote: > "do not work sensibly" imo doesn't sound very good in docs. Maybe > something roughly along the lines of "are unlikely to work as expected > as the on conflict action is only taken in case of unique violation on >

Re: [HACKERS] INSERT ... ON CONFLICT documentation clean-up patch

On Sun, Oct 11, 2015 at 8:54 PM, Peter Geoghegan wrote: > Attached documentation patch is intended to close-out the INSERT ... > ON CONFLICT documentation items from the 9.5 open item list. I also > attach a patch that makes a minor adjustment to an error message > concerning

[HACKERS] INSERT ... ON CONFLICT documentation clean-up patch

Attached documentation patch is intended to close-out the INSERT ... ON CONFLICT documentation items from the 9.5 open item list. I also attach a patch that makes a minor adjustment to an error message concerning deferred constraints; the problem came to my attention as I worked on the