Re: [HACKERS] Ignoring white space in regression tests really a good idea?

2009-11-21 Thread Alex Hunsaker
On Sat, Nov 21, 2009 at 16:07, David E. Wheeler wrote: > On Nov 22, 2009, at 7:49 AM, Tom Lane wrote: > >> I'm thinking maybe we should remove -w.  Comments? > > Have you tried it on the existing tests to see what happens? For me there I get: *the breaking in create_cast *various things in foreig

Re: [HACKERS] Ignoring white space in regression tests really a good idea?

2009-11-21 Thread David E. Wheeler
On Nov 22, 2009, at 7:49 AM, Tom Lane wrote: > I'm thinking maybe we should remove -w. Comments? Have you tried it on the existing tests to see what happens? David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

[HACKERS] Ignoring white space in regression tests really a good idea?

2009-11-21 Thread Tom Lane
pg_regress compares expected and actual output using "diff -w" (a/k/a --ignore-all-space). We have always done this, and I think the idea was to avoid getting a lot of useless diff noise when the only real difference is that one column value in a tabular display is wider than expected. I'm wonder