Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-22 Thread Jan de Visser
On April 22, 2015 11:14:08 AM Heikki Linnakangas wrote: > On 04/16/2015 06:51 AM, Alvaro Herrera wrote: > > Seems reasonable, but why are you sleeping 1s if pg_ctl -w is in use? I > > thought the -w would wait until promotion has taken effect, so there's > > no need to sleep additional time. > >

Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-22 Thread Michael Paquier
On Wed, Apr 22, 2015 at 8:40 PM, Heikki Linnakangas wrote: > On 04/20/2015 05:21 AM, Michael Paquier wrote: >> >> I have just made a run of the TAP tests of pg_rewind on my raspberry >> PI 1 (hamster), where the tests are very slow, and I noticed that it >> takes up to 10s to get confirmation from

Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-22 Thread Heikki Linnakangas
On 04/20/2015 05:21 AM, Michael Paquier wrote: I have just made a run of the TAP tests of pg_rewind on my raspberry PI 1 (hamster), where the tests are very slow, and I noticed that it takes up to 10s to get confirmation from standby that it has caught up with the changes from master, and 5s to g

Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-22 Thread Heikki Linnakangas
On 04/16/2015 06:51 AM, Alvaro Herrera wrote: Seems reasonable, but why are you sleeping 1s if pg_ctl -w is in use? I thought the -w would wait until promotion has taken effect, so there's no need to sleep additional time. -w is not supported with pg_ctl promote. Only start, stop and restart.

Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-19 Thread Michael Paquier
On Thu, Apr 16, 2015 at 1:00 PM, Michael Paquier wrote: > Visibly that's not the case for this test case, the timing issues that > we saw happened not because of the standby not catching up, but > because of the promotion not taking effect in a timely fashion. And > that's as well something I saw o

Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-15 Thread Michael Paquier
On Thu, Apr 16, 2015 at 12:51 PM, Alvaro Herrera wrote: > Michael Paquier wrote: > >> However after discussion with a colleague we have noticed that those >> values may not be enough in slow environments, a value of up to 10s >> being sometimes needed after promotion to make tests pass. > > Yeah, h

Re: [HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-15 Thread Alvaro Herrera
Michael Paquier wrote: > However after discussion with a colleague we have noticed that those > values may not be enough in slow environments, a value of up to 10s > being sometimes needed after promotion to make tests pass. Yeah, hardcoded sleep times are not reliable. (/me would love to get ri

[HACKERS] Improve sleep processing of pg_rewind TAP tests

2015-04-15 Thread Michael Paquier
Hi all, TAP tests of pg_rewind are using in 2 places hardcoded values to wait for a given amount of time for some events. In HEAD, those things are: 1) Wait for 1s for standby to catch up. 2) Wait for 2s for promotion of standby. However after discussion with a colleague we have noticed that those