Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Tom Lane
Andres Freund writes: > On 2014-11-19 19:59:33 +0200, Heikki Linnakangas wrote: >> This grew "pg_dumpall | wc -c" from 5505689 to 6926066 bytes. The size of >> the regression database grew, according to psql's "\l+" command grew from 45 >> MB to 57 MB. The amount of WAL generated by "make installc

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Andres Freund
On 2014-11-19 19:59:33 +0200, Heikki Linnakangas wrote: > On 11/19/2014 05:01 PM, Andres Freund wrote: > >On 2014-11-19 11:54:47 -0300, Alvaro Herrera wrote: > >>Heikki Linnakangas wrote: > >>> Schema | Name | Type | Owner | Size | Description > >>>+--+

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Heikki Linnakangas
On 11/19/2014 05:01 PM, Andres Freund wrote: On 2014-11-19 11:54:47 -0300, Alvaro Herrera wrote: Heikki Linnakangas wrote: Schema | Name | Type | Owner | Size | Description +--+---++-+- public | btree_tall_tbl | tabl

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Tom Lane
Alvaro Herrera writes: > Heikki Linnakangas wrote: >> 2. These make the regression database larger. The following tables and >> indexes are added: > I think it's good to have these tests, though Tom was complaining > earlier about the size of the regression test database. Would it work > to have

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Heikki Linnakangas
On 11/19/2014 04:54 PM, Alvaro Herrera wrote: Also I'm surprised that BRIN did not turn up here. At least the "page evacuation protocol" to obtain a new revmap page is not exercised by the current tests. I suppose it's because all WAL records are covered by other activity, and page evacuation d

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Andres Freund
On 2014-11-19 11:54:47 -0300, Alvaro Herrera wrote: > Heikki Linnakangas wrote: > > Schema | Name | Type | Owner | Size | Description > > +--+---++-+- > > public | btree_tall_tbl | table | heikki | 24 kB | > > public |

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Alvaro Herrera
Heikki Linnakangas wrote: > 2. These make the regression database larger. The following tables and > indexes are added: > > postgres=# \d+ > List of relations > Schema | Name | Type | Owner | Size | Description > +--+---+-

Re: [HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Andres Freund
Hi, On 2014-11-19 16:27:56 +0200, Heikki Linnakangas wrote: > To test WAL replay, I often set up a master-standby system with streaming > replication and run "make installcheck" on the master. However, the > regression suite doesn't generate all WAL record types. I spent some time > looking at the

[HACKERS] Increasing test coverage of WAL redo functions

2014-11-19 Thread Heikki Linnakangas
To test WAL replay, I often set up a master-standby system with streaming replication and run "make installcheck" on the master. However, the regression suite doesn't generate all WAL record types. I spent some time looking at the lcov report (make coverage-html), and crafted new tests to test