Re: [HACKERS] Indicate disabled triggers in \d

2007-01-20 Thread Bruce Momjian
Patch applied by Neil. Thanks. --- Brendan Jurd wrote: On 11/7/06, Brendan Jurd [EMAIL PROTECTED] wrote: As discussed briefly on pgsql-hackers, the current psql \d command does not make any distinction between

Re: [HACKERS] Indicate disabled triggers in \d

2006-11-17 Thread Bruce Momjian
This has been saved for the 8.3 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Brendan Jurd wrote: On 11/7/06, Brendan Jurd [EMAIL PROTECTED] wrote: As discussed briefly on pgsql-hackers, the

Re: [PATCHES] [HACKERS] Indicate disabled triggers in \d

2006-11-10 Thread Neil Conway
On Tue, 2006-11-07 at 16:21 +1100, Brendan Jurd wrote: Minor fix to the previous patch; result7 was not being cleared at the end of the block. The patch still leaks result7 circa line 1400 (CVS HEAD). I didn't look closely, but you probably also leak result7 circa line 1209, if result6 is NULL.

Re: [PATCHES] [HACKERS] Indicate disabled triggers in \d

2006-11-10 Thread Brendan Jurd
On 11/11/06, Neil Conway [EMAIL PROTECTED] wrote: The patch still leaks result7 circa line 1400 (CVS HEAD). I didn't look closely, but you probably also leak result7 circa line 1209, if result6 is NULL. New version of the patch attached (against CVS HEAD) that fixes these two issues. (Yeah,

Re: [HACKERS] Indicate disabled triggers in \d

2006-11-06 Thread Andrew Dunstan
Tom Lane wrote: Brendan Jurd [EMAIL PROTECTED] writes: My first impulse was to just append a (disabled) after each disabled trigger, but perhaps that is not visually obvious enough, especially if the table has many triggers on it. Agreed, but maybe put it up at the front? Triggers:

Re: [HACKERS] Indicate disabled triggers in \d

2006-11-06 Thread David Fetter
On Mon, Nov 06, 2006 at 09:12:32AM -0500, Andrew Dunstan wrote: Tom Lane wrote: Brendan Jurd [EMAIL PROTECTED] writes: My first impulse was to just append a (disabled) after each disabled trigger, but perhaps that is not visually obvious enough, especially if the table has many triggers

Re: [HACKERS] Indicate disabled triggers in \d

2006-11-06 Thread Brendan Jurd
As discussed briefly on pgsql-hackers, the current psql \d command does not make any distinction between enabled and disabled triggers. The attached patch modifies psql's describeOneTableDetails() such that triggers and disabled triggers are displayed as two separate footer lists, for example:

Re: [HACKERS] Indicate disabled triggers in \d

2006-11-06 Thread Brendan Jurd
On 11/7/06, Brendan Jurd [EMAIL PROTECTED] wrote: As discussed briefly on pgsql-hackers, the current psql \d command does not make any distinction between enabled and disabled triggers. The attached patch modifies psql's describeOneTableDetails() such that triggers and disabled triggers are

[HACKERS] Indicate disabled triggers in \d

2006-11-05 Thread Brendan Jurd
Hello hackers, I noticed that the table description given by \d tablename in psql does not indicate whether a trigger is enabled or disabled. In my opinion, if a trigger is disabled, that fact is essential information that a person looking at the output of \d would want to know. I would like

Re: [HACKERS] Indicate disabled triggers in \d

2006-11-05 Thread Tom Lane
Brendan Jurd [EMAIL PROTECTED] writes: My first impulse was to just append a (disabled) after each disabled trigger, but perhaps that is not visually obvious enough, especially if the table has many triggers on it. Agreed, but maybe put it up at the front? Triggers: y AFTER DELETE ON x