Re: [HACKERS] Inefficiency in InitIndexFreeSpaceMap

2008-11-06 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Why is InitIndexFreeSpaceMap coded to test for the FSM file already >> existing? AFAICS it cannot yet exist and it should be an error anyway >> if it does. > Hmm. The FSM file can exist, if the index isn't created anew, but > tr

Re: [HACKERS] Inefficiency in InitIndexFreeSpaceMap

2008-11-05 Thread Heikki Linnakangas
Tom Lane wrote: Why is InitIndexFreeSpaceMap coded to test for the FSM file already existing? AFAICS it cannot yet exist and it should be an error anyway if it does. Hmm. The FSM file can exist, if the index isn't created anew, but truncated and rebuilt. However, we normally create a new relf

[HACKERS] Inefficiency in InitIndexFreeSpaceMap

2008-11-05 Thread Tom Lane
Why is InitIndexFreeSpaceMap coded to test for the FSM file already existing? AFAICS it cannot yet exist and it should be an error anyway if it does. The smgrexists probe is hardly free, so losing it would be good. regards, tom lane -- Sent via pgsql-hackers mailing lis