Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-18 Thread Michael Paquier
On Thu, Mar 19, 2015 at 3:30 AM, Alvaro Herrera wrote: > Makes sense. > > I have pushed your patch; we'll see what the buildfarm thinks of it. Thanks. > (Sadly, the number of MSVC members is rather small and they don't run > often.) Once Windows 10 is out, it could be installed on a Raspberry PI

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-18 Thread Alvaro Herrera
Michael Paquier wrote: > On Wed, Mar 18, 2015 at 3:13 AM, Alvaro Herrera > wrote: > > I mean, can't we just do the "push" unconditionally here? > > Why should we install unnecessary stuff? This complicates the > installation contents, the point being to have only shared libraries's > dll install

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-17 Thread Michael Paquier
On Wed, Mar 18, 2015 at 3:13 AM, Alvaro Herrera wrote: > Michael Paquier wrote: > >> So I have recoded the patch to use an hash of arrays (makes the code >> more readable IMO) to be able to track more easily what to install >> where, and process now does the following for shared libraries: >> - In

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-17 Thread Alvaro Herrera
Michael Paquier wrote: > So I have recoded the patch to use an hash of arrays (makes the code > more readable IMO) to be able to track more easily what to install > where, and process now does the following for shared libraries: > - In lib/, install all .dll and .lib > - In bin/, install all .dll

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-12 Thread Michael Paquier
On Wed, Mar 11, 2015 at 10:03 PM, Asif Naeem wrote: > Thank you Michael overall v3 patch looks good to me, There is one > observation that it is not installing following lib files that are required > for dev work i.e. Thanks for your input. >> inst\lib\libpq.lib >> inst\lib\libpgtypes.lib >> ins

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-12 Thread Asif Naeem
Thank you Michael overall v3 patch looks good to me, There is one observation that it is not installing following lib files that are required for dev work i.e. > > inst\lib\libpq.lib > inst\lib\libpgtypes.lib > inst\lib\libecpg_compat.lib > inst\lib\libecpg.lib Please do let me know if I missed so

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-09 Thread Michael Paquier
On Wed, Mar 4, 2015 at 4:13 AM, Michael Paquier wrote: > Those entries are removed as well in the patch. Please find attached a new version of the patch, fixing a failure for plperl installation that contains GNUmakefile instead of Makefile. -- Michael diff --git a/src/tools/msvc/Install.pm b/src

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-04 Thread Michael Paquier
On Wed, Mar 4, 2015 at 4:43 PM, Michael Paquier wrote: > On Tue, Mar 3, 2015 at 8:36 PM, Asif Naeem wrote: >> Thank you Michael. I have looked the patch. > > Thanks for the review! > >> Overall logic looks good to me, >> I have checked it with MSVC{2013,2008}. It works for MSVC 2013 but fail for >>

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-03 Thread Michael Paquier
On Tue, Mar 3, 2015 at 8:36 PM, Asif Naeem wrote: > Thank you Michael. I have looked the patch. Thanks for the review! > Overall logic looks good to me, > I have checked it with MSVC{2013,2008}. It works for MSVC 2013 but fail for > MSVC 2008, I think the condition "if ($proj =~ > qr{ResourceCom

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-03 Thread Asif Naeem
Thank you Michael. I have looked the patch. Overall logic looks good to me, I have checked it with MSVC{2013,2008}. It works for MSVC 2013 but fail for MSVC 2008, I think the condition "if ($proj =~ qr{ResourceCompile\s*Include="([^"]+)”})” is not going to work for MSVC2008 and MSVC2005 i.e. MSVC2

[HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-01-19 Thread Michael Paquier
Hi all, Here is a continuation of the thread which covered $subject for MinGW and Cygwin: http://www.postgresql.org/message-id/51f19059.7050...@pgexperts.com But this time it is for MSVC. Just a bit of background... Since commit cb4a3b04 we are installing shared libraries in bin/ and lib/ for Cyg