Re: [HACKERS] Is TG_NARGS/TG_ARGV just legacy, or what?

2006-03-04 Thread Tom Lane
Josh Berkus writes: > Triggers seem like the least useful place to have variable-argument > functions, though. And it is inconsistent with how we use functions > everywhere else, as well as in violation of the SQL03 standard on CREATE > FUNCTION (don't know what the standard says about trigge

Re: [HACKERS] Is TG_NARGS/TG_ARGV just legacy, or what?

2006-03-04 Thread Josh Berkus
Andrew, > It does have the advantage that you can call a single trigger function > with variable argument types/numbers. "Fixing" it would involve an > unknown amount of legacy breakage. Yes ... I don't see a good way to maintain legacy compatibility. Triggers seem like the least useful place

Re: [HACKERS] Is TG_NARGS/TG_ARGV just legacy, or what?

2006-03-04 Thread Andrew Dunstan
Josh Berkus said: > Folks, > > I was just building something and noticing the peculiar structure we've > given to arguments to trigger procedures. Instead of declaring them > normally, we pass them through the variables TG_NARGS and TG_ARGV[]. > This is inconsistent with the entire rest of Postg

[HACKERS] Is TG_NARGS/TG_ARGV just legacy, or what?

2006-03-04 Thread Josh Berkus
Folks, I was just building something and noticing the peculiar structure we've given to arguments to trigger procedures. Instead of declaring them normally, we pass them through the variables TG_NARGS and TG_ARGV[]. This is inconsistent with the entire rest of Postgres, as well as making it