Re: [HACKERS] Issues in Replication Progress Tracking

2015-05-22 Thread Amit Kapila
On Sat, May 23, 2015 at 11:19 AM, Andres Freund wrote: > > On May 22, 2015 10:23:06 PM PDT, Amit Kapila wrote: > >On Fri, May 22, 2015 at 11:20 PM, Andres Freund > >wrote: > >> > >> On 2015-05-21 09:40:58 +0530, Amit Kapila wrote: > >> > On Thu, May 21, 2015 at 12:42 AM, Andres Freund > > > >wro

Re: [HACKERS] Issues in Replication Progress Tracking

2015-05-22 Thread Andres Freund
On May 22, 2015 10:23:06 PM PDT, Amit Kapila wrote: >On Fri, May 22, 2015 at 11:20 PM, Andres Freund >wrote: >> >> On 2015-05-21 09:40:58 +0530, Amit Kapila wrote: >> > On Thu, May 21, 2015 at 12:42 AM, Andres Freund > >wrote: >> > > >> > > On 2015-05-20 19:27:05 +0530, Amit Kapila wrote: >> > >

Re: [HACKERS] Issues in Replication Progress Tracking

2015-05-22 Thread Amit Kapila
On Fri, May 22, 2015 at 11:20 PM, Andres Freund wrote: > > On 2015-05-21 09:40:58 +0530, Amit Kapila wrote: > > On Thu, May 21, 2015 at 12:42 AM, Andres Freund wrote: > > > > > > On 2015-05-20 19:27:05 +0530, Amit Kapila wrote: > > > > > > > 13. > > > > In function replorigin_session_setup() and

Re: [HACKERS] Issues in Replication Progress Tracking

2015-05-22 Thread Andres Freund
On 2015-05-21 09:40:58 +0530, Amit Kapila wrote: > On Thu, May 21, 2015 at 12:42 AM, Andres Freund wrote: > > > > On 2015-05-20 19:27:05 +0530, Amit Kapila wrote: > > > > > 13. > > > In function replorigin_session_setup() and or > > > replorigin_session_advance(), don't we need to WAL log the > >

Re: [HACKERS] Issues in Replication Progress Tracking

2015-05-20 Thread Amit Kapila
On Thu, May 21, 2015 at 12:42 AM, Andres Freund wrote: > > On 2015-05-20 19:27:05 +0530, Amit Kapila wrote: > > > 13. > > In function replorigin_session_setup() and or > > replorigin_session_advance(), don't we need to WAL log the > > use of Replication state? > > No, the point is that the replica

Re: [HACKERS] Issues in Replication Progress Tracking

2015-05-20 Thread Andres Freund
Hi, Thanks for looking through this! On 2015-05-20 19:27:05 +0530, Amit Kapila wrote: > 5. > origin.c > > * * To create and drop replication origins an exclusive lock on > * pg_replication_slot is required for the > duration. That allows us to > * safely and conflict free assign new origin

[HACKERS] Issues in Replication Progress Tracking

2015-05-20 Thread Amit Kapila
While reading the commit- 5aa23504 for Replication Progress Tracking, I came across few issues which I would like to share. 1. catalogs.sgml + + local_lsn + pg_lsn + + This node's LSN that at + which remote_lsn has been replicated. Used to + flush commit records befo